Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CI] macOS compile errors due to boost::asio #45053

Closed
pitrou opened this issue Dec 17, 2024 · 2 comments
Closed

[C++][CI] macOS compile errors due to boost::asio #45053

pitrou opened this issue Dec 17, 2024 · 2 comments
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
19.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Dec 17, 2024

Describe the bug, including details regarding any error messages, version, and platform.

See example at https://github.com/apache/arrow/actions/runs/12378188460/job/34549488301?pr=45042#step:12:1551

FAILED: src/arrow/CMakeFiles/arrow_testing_objlib.dir/testing/process.cc.o 
/opt/homebrew/bin/ccache /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DARROW_HAVE_NEON -DARROW_TESTING_EXPORTING -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROCESS_DYN_LINK -DBOOST_PROCESS_HAVE_V1 -DBOOST_PROCESS_HAVE_V2 -DBOOST_PROCESS_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -I/Users/runner/work/arrow/arrow/build/cpp/src -I/Users/runner/work/arrow/arrow/cpp/src -I/Users/runner/work/arrow/arrow/cpp/src/generated -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/googletest-src/googletest/include -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/googletest-src/googletest -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/googletest-src/googlemock/include -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/googletest-src/googlemock -isystem /Users/runner/work/arrow/arrow/cpp/thirdparty/flatbuffers/include -isystem /opt/homebrew/Cellar/rapidjson/1.1.0/include -isystem /opt/homebrew/include -fno-aligned-new  -Qunused-arguments -fcolor-diagnostics  -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -g -Werror -O0 -ggdb -g1 -std=c++17 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -MD -MT src/arrow/CMakeFiles/arrow_testing_objlib.dir/testing/process.cc.o -MF src/arrow/CMakeFiles/arrow_testing_objlib.dir/testing/process.cc.o.d -o src/arrow/CMakeFiles/arrow_testing_objlib.dir/testing/process.cc.o -c /Users/runner/work/arrow/arrow/cpp/src/arrow/testing/process.cc
/Users/runner/work/arrow/arrow/cpp/src/arrow/testing/process.cc:88:18: error: expected namespace name
namespace asio = BOOST_PROCESS_V2_ASIO_NAMESPACE;
                 ^
/Users/runner/work/arrow/arrow/cpp/src/arrow/testing/process.cc:246:3: error: use of undeclared identifier 'asio'; did you mean 'boost::asio'?
  asio::io_context ctx_;
  ^~~~
  boost::asio
/opt/homebrew/include/boost/asio/writable_pipe.hpp:26:11: note: 'boost::asio' declared here
namespace asio {
          ^
2 errors generated.

Component(s)

C++, Continuous Integration
@pitrou
Copy link
Member Author

pitrou commented Dec 17, 2024

cc @kou

kou added a commit to kou/arrow that referenced this issue Dec 18, 2024
@kou
apacheGH-45053: [C++] Add support for Boost 1.87.0
81cba3c
kou added a commit to kou/arrow that referenced this issue Dec 18, 2024
@kou
apacheGH-45053: [C++] Add support for Boost 1.87.0
c46efb3
@github-actions github-actions bot mentioned this issue Dec 18, 2024
Merged
kou added a commit that referenced this issue Dec 18, 2024
@kou
GH-45053: [C++] Add support for Boost 1.87.0 (#45057)
5ec8b64 
### Rationale for this change

Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`:
boostorg/process@e827d14

### What changes are included in this PR?

Use `BOOST_PROCESS_V2_NAMESPACE::net` instead.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #45053

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 19.0.0 milestone Dec 18, 2024
@kou
Copy link
Member

kou commented Dec 18, 2024

Issue resolved by pull request 45057
#45057

@kou kou closed this as completed Dec 18, 2024
lriggs pushed a commit to lriggs/arrow that referenced this issue Dec 26, 2024
@kou @lriggs
apacheGH-45053: [C++] Add support for Boost 1.87.0 (apache#45057)
b02259e 
### Rationale for this change

Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`:
boostorg/process@e827d14

### What changes are included in this PR?

Use `BOOST_PROCESS_V2_NAMESPACE::net` instead.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#45053

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou mentioned this issue Dec 31, 2024
Closed
lriggs pushed a commit to lriggs/arrow that referenced this issue Jan 2, 2025
@kou @lriggs
apacheGH-45053: [C++] Add support for Boost 1.87.0 (apache#45057)
bb4cfc7 
### Rationale for this change

Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`:
boostorg/process@e827d14

### What changes are included in this PR?

Use `BOOST_PROCESS_V2_NAMESPACE::net` instead.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#45053

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @pitrou