Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release][Archery][Packaging] Can't use dev/release/03-binary-submit.sh on main to release #44706

Closed
kou opened this issue Nov 13, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Nov 13, 2024

Describe the bug, including details regarding any error messages, version, and platform.

SO (shared object) versions are written literally in dev/tasks/tasks.yml:

arrow/dev/tasks/tasks.yml

Lines 498 to 569 in aab7d81

artifacts:
- arrow-tools_{no_rc_version}-1_[a-z0-9]+.deb
{% if architecture == "amd64" %}
- apache-arrow-apt-source_{no_rc_version}-1.debian.tar.xz
- apache-arrow-apt-source_{no_rc_version}-1.dsc
- apache-arrow-apt-source_{no_rc_version}-1_all.deb
- apache-arrow-apt-source_{no_rc_version}.orig.tar.gz
- apache-arrow_{no_rc_version}-1.debian.tar.xz
- apache-arrow_{no_rc_version}-1.dsc
- apache-arrow_{no_rc_version}.orig.tar.gz
{% endif %}
- gir1.2-arrow-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- gir1.2-arrow-dataset-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- gir1.2-arrow-flight-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- gir1.2-arrow-flight-sql-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- gir1.2-gandiva-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- gir1.2-parquet-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-acero-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-acero1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-acero1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dataset-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dataset-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dataset-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dataset-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-dataset-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dataset1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-dataset1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-flight-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-sql-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-sql-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-sql-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-sql-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-flight-sql-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight-sql1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-flight-sql1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-flight1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-flight1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow1900_{no_rc_version}-1_[a-z0-9]+.deb
- libgandiva-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libgandiva-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libgandiva-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libgandiva-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libgandiva-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libgandiva1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libgandiva1900_{no_rc_version}-1_[a-z0-9]+.deb
- libparquet-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libparquet-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libparquet-glib-doc_{no_rc_version}-1_[a-z0-9]+.deb
- libparquet-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libparquet-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libparquet1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libparquet1900_{no_rc_version}-1_[a-z0-9]+.deb
- parquet-tools_{no_rc_version}-1_[a-z0-9]+.deb
{% if architecture == "amd64" %}
- gir1.2-arrow-cuda-1.0_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-cuda-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-cuda-glib-dev_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-cuda-glib1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-cuda-glib1900_{no_rc_version}-1_[a-z0-9]+.deb
- libarrow-cuda1900-dbgsym_{no_rc_version}-1_[a-z0-9]+.d?deb
- libarrow-cuda1900_{no_rc_version}-1_[a-z0-9]+.deb
{% endif %}

So we can't use dev/release/03-binary-submit.sh on main to release. If we use dev/release/03-binary-submit.sh on main to release 18.1.0, SO version on main (1900 now) is used not 1810.

Component(s)

Archery, Packaging, Release

@kou kou added the Type: bug label Nov 13, 2024
raulcd pushed a commit that referenced this issue Nov 13, 2024
…4707)

### Rationale for this change

SO versions must be computed from the target version instead of embedding them to `dev/tasks/tasks.yaml`. Because they depend on the specified version as an argument.

### What changes are included in this PR?

Add `so_version` variable that can be used in `dev/tasks/tasks.yml`.

### Are these changes tested?

Yes.

#44699 (comment) used this.

### Are there any user-facing changes?

No.
* GitHub Issue: #44706

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 19.0.0 milestone Nov 13, 2024
@raulcd
Copy link
Member

raulcd commented Nov 13, 2024

Issue resolved by pull request 44707
#44707

@raulcd raulcd closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants