Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][Archery] Can't disable Java #44300

Closed
kou opened this issue Oct 4, 2024 · 1 comment
Closed

[Integration][Archery] Can't disable Java #44300

kou opened this issue Oct 4, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Oct 4, 2024

Describe the bug, including details regarding any error messages, version, and platform.

We have an option to disable Java integration test: --with-java=0

If we use it, the following error is occurred:

$ archery docker run -e ARROW_INTEGRATION_JAVA=OFF conda-integration
...
Traceback (most recent call last):
  File "/opt/conda/envs/arrow/bin/archery", line 33, in <module>
    sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/arrow/dev/archery/archery/cli.py", line 833, in integration
    from .integration.runner import write_js_test_json, run_all_tests
  File "/arrow/dev/archery/archery/integration/runner.py", line 37, in <module>
    from .tester_java import JavaTester
  File "/arrow/dev/archery/archery/integration/tester_java.py", line 54, in <module>
    _arrow_version = load_version_from_pom()
                     ^^^^^^^^^^^^^^^^^^^^^^^
  File "/arrow/dev/archery/archery/integration/tester_java.py", line 37, in load_version_from_pom
    tree = ET.parse(os.path.join(ARROW_BUILD_ROOT, 'java', 'pom.xml'))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/xml/etree/ElementTree.py", line 1219, in parse
    tree.parse(source, parser)
  File "/opt/conda/envs/arrow/lib/python3.11/xml/etree/ElementTree.py", line 570, in parse
    source = open(source, "rb")
             ^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/build/java/pom.xml'

Component(s)

Archery, Integration

@kou kou added the Type: bug label Oct 4, 2024
kou added a commit to kou/arrow that referenced this issue Oct 4, 2024
Some testers such as `JavaTester` may raise an exception on import
when the target implementation isn't built. It stops integration test
unexpectedly.
raulcd pushed a commit that referenced this issue Oct 4, 2024
### Rationale for this change

Some testers such as `JavaTester` may raise an exception on import when the target implementation isn't built. It stops integration test unexpectedly.

### What changes are included in this PR?

Import testers only for enabled implementations.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #44300

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 18.0.0 milestone Oct 4, 2024
@raulcd
Copy link
Member

raulcd commented Oct 4, 2024

Issue resolved by pull request 44301
#44301

@raulcd raulcd closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants