Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Archery][Integration] Rename "language" to "implementation" #44155

Closed
kou opened this issue Sep 18, 2024 · 1 comment
Closed

[Archery][Integration] Rename "language" to "implementation" #44155

kou opened this issue Sep 18, 2024 · 1 comment
Assignees
@kou
Labels
Component: Developer Tools Component: Integration Type: enhancement
Milestone
18.0.0

Comments

@kou
Copy link
Member

kou commented Sep 18, 2024 •
edited
Loading

Describe the enhancement requested

Because there is not a language, nanoarrow, for integration test targets.

See also: #44099 (comment)

Component(s)

Developer Tools, Integration
@kou kou mentioned this issue Sep 18, 2024
Merged
@kou kou changed the title [Archery][Integration] Rename --target-language/ARCHERY_INTEGRATION_TARGET_LANGUAGES to "implementation" [Archery][Integration] Rename "language" to "implementation" Sep 18, 2024
kou added a commit to kou/arrow that referenced this issue Sep 18, 2024
@kou
apacheGH-44155: [Archery][Integration] Rename "language" to "implemen…
2ef61c3 
…tation"

Because there is not a language, nanoarrow, for integration test
targets.
@github-actions github-actions bot mentioned this issue Sep 18, 2024
Merged
kou added a commit that referenced this issue Sep 19, 2024
@kou
GH-44155: [Archery][Integration] Rename "language" to "implementation" (
a6f736c 
#44156)

### Rationale for this change

Because there is not a language, nanoarrow, for integration test targets.

### What changes are included in this PR?

* Rename "language" to "implementation" in documents and variable names
* Rename `--target-languages` to `--target-implementations`
* Rename `ARCHERY_INTEGRATION_TARGET_LANGUAGES` to `ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #44155

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Sep 19, 2024
@kou
Copy link
Member Author

kou commented Sep 19, 2024

Issue resolved by pull request 44156
#44156

@kou kou closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Developer Tools Component: Integration Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@kou