Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLib][FlightRPC] ArrowFlight: invalid "closure" annotation: only valid on callback parameters #44153

Closed
kou opened this issue Sep 18, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Sep 18, 2024

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/actions/runs/10913563089/job/30290249018#step:9:262

FAILED: arrow-flight-glib/ArrowFlight-1.0.gir 
env PKG_CONFIG_PATH=/tmp/local/lib/pkgconfig:/Users/runner/work/arrow/arrow/build/c_glib/meson-uninstalled PKG_CONFIG=/opt/homebrew/bin/pkg-config 'CC=ccache cc' /opt/homebrew/Cellar/gobject-introspection/1.82.0/bin/g-ir-scanner --quiet --no-libtool --namespace=ArrowFlight --nsversion=1.0 --warn-all --output arrow-flight-glib/ArrowFlight-1.0.gir --c-include=arrow-flight-glib/arrow-flight-glib.h --warn-all --include-uninstalled=./arrow-glib/Arrow-1.0.gir -I/Users/runner/work/arrow/arrow/c_glib/arrow-flight-glib -I/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib -I/Users/runner/work/arrow/arrow/c_glib/. -I/Users/runner/work/arrow/arrow/build/c_glib/. --filelist=/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib/libarrow-flight-glib.1800.dylib.p/ArrowFlight_1.0_gir_filelist --include=Arrow-1.0 --symbol-prefix=gaflight --identifier-prefix=GAFlight --pkg-export=arrow-flight-glib --cflags-begin -I/Users/runner/work/arrow/arrow/c_glib/. -I/Users/runner/work/arrow/arrow/build/c_glib/. -I/tmp/local/include -I/opt/homebrew/Cellar/glib/2.82.0/include -I/opt/homebrew/Cellar/glib/2.82.0/include/glib-2.0 -I/opt/homebrew/Cellar/glib/2.82.0/lib/glib-2.0/include -I/opt/homebrew/opt/gettext/include -I/opt/homebrew/Cellar/pcre2/10.44/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -I/opt/homebrew/Cellar/gobject-introspection/1.82.0/include/gobject-introspection-1.0 --cflags-end --add-include-path=/Users/runner/work/arrow/arrow/build/c_glib/arrow-glib --add-include-path=/opt/homebrew/Cellar/gobject-introspection/1.82.0/share/gir-1.0 -L/Users/runner/work/arrow/arrow/build/c_glib/arrow-flight-glib --library arrow-flight-glib -L/Users/runner/work/arrow/arrow/build/c_glib/arrow-glib -L/tmp/local/lib -L/opt/homebrew/Cellar/glib/2.82.0/lib -L/opt/homebrew/opt/gettext/lib -L/tmp/local/lib --extra-library=arrow_flight --extra-library=arrow --extra-library=arrow_acero -L/opt/homebrew/Cellar/glib/2.82.0/lib -L/opt/homebrew/opt/gettext/lib --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=intl -L/opt/homebrew/Cellar/gobject-introspection/1.82.0/lib --extra-library=girepository-1.0 --sources-top-dirs /Users/runner/work/arrow/arrow/c_glib/ --sources-top-dirs /Users/runner/work/arrow/arrow/build/c_glib/ --warn-error
ld: warning: duplicate -rpath '/tmp/local/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/opt/gettext/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/Cellar/glib/2.82.0/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/Cellar/glib/2.82.0/lib' ignored
ld: warning: duplicate -rpath '/opt/homebrew/opt/gettext/lib' ignored
ld: warning: ignoring duplicate libraries: '-lglib-2.0', '-lgobject-2.0', '-lintl'
../../c_glib/arrow-flight-glib/client.cpp:278: Warning: ArrowFlight: invalid "closure" annotation: only valid on callback parameters
../../c_glib/arrow-flight-glib/server.cpp:465: Warning: ArrowFlight: invalid "closure" annotation: only valid on callback parameters
<unknown>:: Fatal: ArrowFlight: warnings configured as fatal
<unknown>:: Fatal: ArrowFlight: warnings configured as fatal

Component(s)

FlightRPC, GLib

@kou kou added the Type: bug label Sep 18, 2024
kou added a commit to kou/arrow that referenced this issue Sep 18, 2024
It should be added to a callback function not data for the callback
function.
kou added a commit that referenced this issue Sep 18, 2024
### Rationale for this change

It should be added to a callback function not data for the callback function.

### What changes are included in this PR?

Move annotation location.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #44153

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Sep 18, 2024
@kou
Copy link
Member Author

kou commented Sep 18, 2024

Issue resolved by pull request 44154
#44154

@kou kou closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant