Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Consider warnings as errors for Format Module #44016

Closed
Tracked by #59
vibhatha opened this issue Sep 9, 2024 · 1 comment
Closed
Tracked by #59

[Java] Consider warnings as errors for Format Module #44016

vibhatha opened this issue Sep 9, 2024 · 1 comment
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
18.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Sep 9, 2024

Describe the enhancement requested

As discussed in apache/arrow-java#59, the format module needs to be configured to show all warnings as errors.

Component(s)

Java
@github-actions github-actions bot mentioned this issue Sep 9, 2024
Merged
danepitkin pushed a commit that referenced this issue Sep 10, 2024
@vibhatha @lidavidm
GH-44016: [Java] Consider warnings as errors for Format Module (#44017)
22a4496 
### Rationale for this change

This PR configs the build such that warnings are considered errors in the Format module. And corresponding code changes have also been made.

### What changes are included in this PR?

Adding flags to consider warnings as errors in javac and fixing the corresponding errors.

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

N/A
* GitHub Issue: #44016

Lead-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: David Li <[email protected]>
Signed-off-by: Dane Pitkin <[email protected]>
@danepitkin
Copy link
Member

Issue resolved by pull request 44017
#44017

@danepitkin danepitkin added this to the 18.0.0 milestone Sep 10, 2024
@vibhatha vibhatha mentioned this issue Sep 12, 2024
Open
12 tasks
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@vibhatha @lidavidm @khwilson
apacheGH-44016: [Java] Consider warnings as errors for Format Module (a…
3fb6e58 
…pache#44017)

### Rationale for this change

This PR configs the build such that warnings are considered errors in the Format module. And corresponding code changes have also been made.

### What changes are included in this PR?

Adding flags to consider warnings as errors in javac and fixing the corresponding errors.

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

N/A
* GitHub Issue: apache#44016

Lead-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: David Li <[email protected]>
Signed-off-by: Dane Pitkin <[email protected]>
zeroshade pushed a commit to zeroshade/arrow that referenced this issue Sep 30, 2024
@vibhatha @lidavidm @zeroshade
apacheGH-44016: [Java] Consider warnings as errors for Format Module (a…
877f541 
…pache#44017)

### Rationale for this change

This PR configs the build such that warnings are considered errors in the Format module. And corresponding code changes have also been made.

### What changes are included in this PR?

Adding flags to consider warnings as errors in javac and fixing the corresponding errors.

### Are these changes tested?

Tested by existing test cases.

### Are there any user-facing changes?

N/A
* GitHub Issue: apache#44016

Lead-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Co-authored-by: David Li <[email protected]>
Signed-off-by: Dane Pitkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@vibhatha @danepitkin