Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][CI] Remove Go related lint configurations #43875

Closed
kou opened this issue Aug 29, 2024 · 1 comment
Closed

[Go][CI] Remove Go related lint configurations #43875

kou opened this issue Aug 29, 2024 · 1 comment
Assignees
@raulcd
Labels
Component: Continuous Integration Component: Developer Tools Component: Go Type: enhancement
Milestone
18.0.0

Comments

@kou
Copy link
Member

kou commented Aug 29, 2024 •
edited
Loading

Describe the enhancement requested

After apache/arrow-go#1.

arrow/.pre-commit-config.yaml

Lines 151 to 164 in 58415d1

- repo: https://github.com/golangci/golangci-lint
rev: v1.59.0
hooks:
# no built-in support for multiple go.mod
# https://github.com/golangci/golangci-lint/issues/828
- id: golangci-lint-full
name: golangci-lint-full-arrow
entry: bash -c 'cd go/arrow && golangci-lint run'
- id: golangci-lint-full
name: golangci-lint-full-parquet
entry: bash -c 'cd go/parquet && golangci-lint run'
- id: golangci-lint-full
name: golangci-lint-full-internal
entry: bash -c 'cd go/internal && golangci-lint run'

Component(s)

Continuous Integration, Developer Tools, Go
@kou kou mentioned this issue Aug 29, 2024
Closed
@raulcd raulcd added this to the 18.0.0 milestone Sep 13, 2024
@raulcd raulcd self-assigned this Sep 17, 2024
raulcd added a commit to raulcd/arrow that referenced this issue Sep 17, 2024
@raulcd
apacheGH-43875: [Go][CI] Remove Go related lint configurations
7db3317
@github-actions github-actions bot mentioned this issue Sep 17, 2024
Merged
kou pushed a commit that referenced this issue Sep 18, 2024
@raulcd
GH-43875: [Go][CI] Remove Go related lint configurations (#44144)
7d33f93 
### Rationale for this change

The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.

### What changes are included in this PR?

Removing the linting configuration

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: #43875

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member Author

kou commented Sep 18, 2024

Issue resolved by pull request 44144
#44144

@kou kou closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Component: Developer Tools Component: Go Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd