-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] ChunkedArray should fail gracefully on non-cpu devices #43728
Labels
Component: Python
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
Type: enhancement
Milestone
Comments
danepitkin
changed the title
[Python] Table fails gracefully on non-cpu devices
[Python] Table/ChunkedArray fails gracefully on non-cpu devices
Aug 16, 2024
danepitkin
changed the title
[Python] Table/ChunkedArray fails gracefully on non-cpu devices
[Python] Table/ChunkedArray should fail gracefully on non-cpu devices
Aug 16, 2024
amoeba
added
the
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Aug 16, 2024
danepitkin
changed the title
[Python] Table/ChunkedArray should fail gracefully on non-cpu devices
[Python] ChunkedArray should fail gracefully on non-cpu devices
Aug 22, 2024
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Aug 22, 2024
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Aug 23, 2024
…cpu devices" This reverts commit 1fcdb1f.
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Aug 29, 2024
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Aug 29, 2024
…cpu devices" This reverts commit 1fcdb1f.
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Sep 3, 2024
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Sep 3, 2024
…cpu devices" This reverts commit 1fcdb1f.
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Sep 4, 2024
danepitkin
added a commit
to danepitkin/arrow
that referenced
this issue
Sep 4, 2024
…cpu devices" This reverts commit 1fcdb1f.
danepitkin
added a commit
that referenced
this issue
Sep 4, 2024
…43795) ### Rationale for this change ChunkedArrays that are backed by non-cpu memory should not segfault when the user invokes an incompatible API. ### What changes are included in this PR? * Add IsCpu() to ChunkedArray * Throw a python exception for known incompatible APIs on non-cpu device ### Are these changes tested? Unit tests ### Are there any user-facing changes? The user should no longer see segfaults for certain APIs, just python exceptions. * GitHub Issue: #43728 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Dane Pitkin <[email protected]>
Issue resolved by pull request 43795 |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Sep 6, 2024
…ices (apache#43795) ### Rationale for this change ChunkedArrays that are backed by non-cpu memory should not segfault when the user invokes an incompatible API. ### What changes are included in this PR? * Add IsCpu() to ChunkedArray * Throw a python exception for known incompatible APIs on non-cpu device ### Are these changes tested? Unit tests ### Are there any user-facing changes? The user should no longer see segfaults for certain APIs, just python exceptions. * GitHub Issue: apache#43728 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Dane Pitkin <[email protected]>
Closed
4 tasks
khwilson
pushed a commit
to khwilson/arrow
that referenced
this issue
Sep 14, 2024
…ices (apache#43795) ### Rationale for this change ChunkedArrays that are backed by non-cpu memory should not segfault when the user invokes an incompatible API. ### What changes are included in this PR? * Add IsCpu() to ChunkedArray * Throw a python exception for known incompatible APIs on non-cpu device ### Are these changes tested? Unit tests ### Are there any user-facing changes? The user should no longer see segfaults for certain APIs, just python exceptions. * GitHub Issue: apache#43728 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Dane Pitkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Python
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
Type: enhancement
Describe the enhancement requested
ChunkedArray should throw Python exceptions instead of segfaults when trying to access non-cpu data from the cpu.
Component(s)
Python
The text was updated successfully, but these errors were encountered: