GH-43506: [Java] Fix TestFragmentScanOptions result not match

[jinchengchenghh]

Rationale for this change

JNI test was not tested in CI. So the test failed but passed the CI.
The parseChar function should return char but return bool, a typo error.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No

• GitHub Issue: [Java] Fix TestFragmentScanOptions test result does not match #43506
• GitHub Issue: [Java] Fix TestFragmentScanOptions test result does not match #43506

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[vibhatha]

Rename to -> #43506: [Java] Fix TestFragmentScanOptions result not match

[vibhatha]

@github-actions crossbow submit -g java

[github-actions]

Revision: ea541c6

Submitted crossbow builds: ursacomputing/crossbow @ actions-acd4c173ff

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

[vibhatha]

@jinchengchenghh I think still there is an inaccuracy in the test case. One CI is failing.

[vibhatha]

Still the CI is failing...

[vibhatha]

Still failing right...

[github-actions]

⚠️ GitHub issue #43506 has been automatically assigned in GitHub to PR creator.

[jinchengchenghh]

I will take a look today.

[jinchengchenghh]

Only gandiva failed now. @vibhatha

[vibhatha]

@jinchengchenghh it seems like there is a symbol not found issue again; https://github.com/apache/arrow/actions/runs/10363135011/job/28686234425?pr=43639#step:7:20512

[jinchengchenghh]

Do I need to disable this test in this PR? Or you will create a new PR to disable it?

[vibhatha]

@kou shall we disable this like the last time but note this as an issue and comment in the code?

[kou]

Yes but why is this happen again? Was #43503 not enough?

[vibhatha]

Yes but why is this happen again? Was #43503 not enough?

The tests related to Gandiva passed when we merged that PR, but it failed due to the exact reason in this PR. We might have missed something as it seems.

[jinchengchenghh]

Yes, this test ProjectorTest.testMakeProjectorParallel is not disabled while ProjectorTest.testMakeProjector is disabled.
https://github.com/apache/arrow/blob/main/java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorTest.java#L152

Does it not occur before?

[vibhatha]

We should check that trace. We may have missed it.

[vibhatha]

@jinchengchenghh let's disable this too.

[jinchengchenghh]

Yes, I think we could disable the gandiva test in a separate PR. Can we merge this one first? @vibhatha

[lidavidm]

@github-actions crossbow submit -g java

[github-actions]

Revision: 855a3af

Submitted crossbow builds: ursacomputing/crossbow @ actions-7af4649f9c

Task	Status
java-jars
test-conda-python-3.11-spark-master
verify-rc-source-java-linux-almalinux-8-amd64
verify-rc-source-java-linux-conda-latest-amd64
verify-rc-source-java-linux-ubuntu-20.04-amd64
verify-rc-source-java-linux-ubuntu-22.04-amd64
verify-rc-source-java-macos-amd64

[jinchengchenghh]

Can you help merge this one? @vibhatha Thanks!

[vibhatha]

@jinchengchenghh I don't have merge rights. @lidavidm will definitely merge this as it is already approved. LGTM as well.

[jinchengchenghh]

Ok. Thanks for your kindly review. @vibhatha

[vibhatha]

@jinchengchenghh did we file a new issue for the Gandiva failure?

[jinchengchenghh]

Maybe we can use the exists issue apache/arrow-java#63

[vibhatha]

Sure let's do that.

[lidavidm]

@vibhatha do we need to ping any Gandiva maintainers to figure out the failures?

[vibhatha]

@lidavidm I think so. And I think @kou also tried to fix this earlier.

[lidavidm]

ok, let me dig

[vibhatha]

Thanks @lidavidm, I am not well versed in this part of the project.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5ef7e01.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.