Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Add StructArray Builders #43168

Closed
abandy opened this issue Jul 6, 2024 · 1 comment
Closed

[Swift] Add StructArray Builders #43168

abandy opened this issue Jul 6, 2024 · 1 comment
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
18.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Jul 6, 2024

Describe the enhancement requested

Need to add buffer and array builders for StructArray type.

Component(s)

Swift
abandy added a commit to abandy/arrow that referenced this issue Jul 6, 2024
@abandy
apacheGH-43168: Add buffer and array builders for Struct type
be5a534
@github-actions github-actions bot mentioned this issue Jul 6, 2024
Merged
abandy added a commit to abandy/arrow that referenced this issue Jul 9, 2024
@abandy
apacheGH-43168: Add buffer and array builders for Struct type
4ba8d8c
abandy added a commit to abandy/arrow that referenced this issue Jul 11, 2024
@abandy
apacheGH-43168: Add buffer and array builders for Struct type
53b09f4
kou pushed a commit that referenced this issue Jul 18, 2024
@abandy
GH-43168: [Swift] Add buffer and array builders for Struct type (#43171)
0bae073 
### Rationale for this change
The struct type requires additions/modifications to builders for buffers and arrays.   This is needed in order match functionality with the other supported types.

### What changes are included in this PR?
Updates to buffer and array builders for Struct type.

### Are these changes tested?
Yes, Array test has been added for the Struct type using the Struct builders

**This PR includes breaking changes to public APIs.**
The init method for ArrowArray currently does not throw.  This PR will change this behavior and allow the init method to throw.  External code that calls init will need to be updated to catch any errors. 

* GitHub Issue: #43168

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Jul 18, 2024
@kou
Copy link
Member

kou commented Jul 18, 2024

Issue resolved by pull request 43171
#43171

@kou kou closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @abandy