Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C][Python] Vendor pythoncapi-compat instead of adjusting changes manually #43069

Closed
raulcd opened this issue Jun 26, 2024 · 1 comment
Closed

[C][Python] Vendor pythoncapi-compat instead of adjusting changes manually #43069

raulcd opened this issue Jun 26, 2024 · 1 comment
Assignees
@jorisvandenbossche
Labels
Component: C++ Component: Python Type: enhancement
Milestone
18.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jun 26, 2024

Describe the enhancement requested

This issue is an enhancement follow up from this comment: #42034 (comment)

Based on the discussion:
Vendoring it should be trivial: there is a single .h file.

Component(s)

C++, Python
@raulcd raulcd mentioned this issue Jun 26, 2024
Merged
@jorisvandenbossche jorisvandenbossche mentioned this issue Aug 5, 2024
Merged
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Aug 20, 2024
@jorisvandenbossche
apacheGH-43069: [Python] Use Py_IsFinalizing from pythoncapi_compat.h
ced26cb
@jorisvandenbossche jorisvandenbossche mentioned this issue Aug 20, 2024
Merged
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Aug 20, 2024
@jorisvandenbossche
apacheGH-43069: [Python] Use Py_IsFinalizing from pythoncapi_compat.h
2a03a7d
jorisvandenbossche added a commit that referenced this issue Aug 21, 2024
@jorisvandenbossche
GH-43069: [Python] Use Py_IsFinalizing from pythoncapi_compat.h (#43767)
9fc0301 
### Rationale for this change

#43540 already vendored `pythoncapi_compat.h`, so closing #43069 by using this as well for `Py_IsFinalizing` (which was added in #42034, and for which we opened that follow-up issue to use  `pythoncapi_compat.h` instead)

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche added this to the 18.0.0 milestone Aug 21, 2024
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 43767
#43767

@jorisvandenbossche jorisvandenbossche self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: C++ Component: Python Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@raulcd @jorisvandenbossche