Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update Unit Tests for Adapter Module #42030

Closed
Tracked by #41680
llama90 opened this issue Jun 7, 2024 · 1 comment
Closed
Tracked by #41680

[Java] Update Unit Tests for Adapter Module #42030

llama90 opened this issue Jun 7, 2024 · 1 comment

Comments

@llama90
Copy link
Contributor

llama90 commented Jun 7, 2024

Describe the enhancement requested

This is a sub-issue of the issue below.

The unit tests should use the org.junit.jupiter.api package. This issue deals with the adapter module.

Component(s)

Java

lidavidm pushed a commit that referenced this issue Jun 14, 2024
### Rationale for this change

Update package from JUnit 4(`org.junit`) to JUnit 5(`org.junit.jupiter`).

### What changes are included in this PR?

- `avro` and `jdbc` module
  - [x] Replacing `org.junit` with `org.junit.jupiter.api`.
  - [x] Updating `Assertions.assertXXX` to `assertXXX` using static imports.
  - [x] Updating annotations such as `@ Before`, `@ After`.
    - `@ Before` -> `@ BeforeEach`
    - `@ After` -> `@ AfterEach`
    - `@ Test` -> `@ Test` with `org.junit.jupiter`
    - `@ ClassRule` -> `@ TempDir` and `@ BeforeAll`
  - [x] Updating `Parameterized` test
  - [x] Doing self review for avro
  - [x] Dealing with `java.io.IOException: Failed to delete temp directory` on Windows with JDK 11
  - [x] Exploring a more effective structure for `ParameterizedTest` in JDBC tests.
  - [x] Doing self review for jdbc
- `orc` module
  - [x] Reviewing the build method
  - [x] Updating annotations such as `@ BeforeAll`, `@ Rule`, `@ TemporaryFolder`
  - [x] Doing self review

### Are these changes tested?

Yes, existing tests have passed.

### Are there any user-facing changes?

No.

* GitHub Issue: #42030

Authored-by: Hyunseok Seo <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm
Copy link
Member

Issue resolved by pull request 42038
#42038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants