Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] take into account orc's capabilities for finding tzdb #41755

Closed
h-vetinari opened this issue May 21, 2024 · 1 comment
Closed

[C++] take into account orc's capabilities for finding tzdb #41755

h-vetinari opened this issue May 21, 2024 · 1 comment
Assignees
@h-vetinari
Labels
Component: C++ Component: Packaging Component: Python Type: enhancement
Milestone
17.0.0

Comments

@h-vetinari
Copy link
Contributor

Describe the enhancement requested

As one of the follow-ups to #36026, apache/orc#1882 got merged into orc 2.0.1, which will use conda(-forge)'s tzdata also on windows, even if the TZDIR environment variable is not being set (inserting that variable into all user environments would have been very intrusive).

Based on this new functionality, I've successfully added orc-on-python support to arrow v13-v15, but some of the other checks introduced in the context of #36026 now fail in conda-forge/pyarrow-feedstock#122, because they haven't yet been taught to allow the case that orc>=2.0.1 now handles.

Component(s)

C++, Packaging, Python
@h-vetinari h-vetinari mentioned this issue May 21, 2024
Merged
h-vetinari added a commit to h-vetinari/arrow that referenced this issue May 27, 2024
@h-vetinari
apacheGH-41755: [C++][ORC] ensure orc version gets set correctly
d1cf6b9 
Suggested-By: Sutou Kouhei <[email protected]>
kou pushed a commit that referenced this issue May 27, 2024
@h-vetinari
GH-41755: [C++][ORC] Ensure setting detected ORC version (#41767)
ff9921f 
`FindorcAlt.cmake` doesn't set `orcAlt_VERSION` when it finds ORC by `find_library()`/`find_path()`. If `orcAlt_VERSION` isn't set, ORC version detection by caller is failed.

`cpp/src/arrow/adapters/orc/adapter.cc` uses detected ORC version. If detected ORC version isn't correct, needless time zone database check is used.

Deployed in conda-forge through conda-forge/arrow-cpp-feedstock#1424 and confirmed as working in conda-forge/pyarrow-feedstock#122
* GitHub Issue: #41755

Authored-by: H. Vetinari <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 17.0.0 milestone May 27, 2024
@kou
Copy link
Member

kou commented May 27, 2024

Issue resolved by pull request 41767
#41767

@kou kou closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-vetinari h-vetinari

Labels
Component: C++ Component: Packaging Component: Python Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@kou @h-vetinari