Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] ASOF join and sortedmerge join don't work in single threaded mode #41190

Closed
joemarshall opened this issue Apr 13, 2024 · 1 comment
Closed

[C++] ASOF join and sortedmerge join don't work in single threaded mode #41190

joemarshall opened this issue Apr 13, 2024 · 1 comment
Assignees
@joemarshall
Labels
Component: C++ Type: bug
Milestone
17.0.0

Comments

@joemarshall
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Currently, if ARROW_ENABLE_THREADING is not set, asof join and sortedmergejoin are not implemented. This is because the current implementation uses std::thread internally, and I tried not to mess with any class internal code while creating the single threaded mode.

This could do with fixing, as I'm mid porting python to add single threaded support, and otherwise a load of tests will break.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Apr 13, 2024
Merged
@amoeba amoeba changed the title ASOF join and sortedmerge join don't work in single threaded mode [C++] ASOF join and sortedmerge join don't work in single threaded mode Apr 17, 2024
westonpace pushed a commit that referenced this issue May 29, 2024
@joemarshall @zanmato1984
GH-41190: [C++] support for single threaded joins (#41125)
a2453bd 
When I initially added single threading support, I didn't do asof joins and sorted merge joins, because the code for these operations uses threads internally. This is a small check-in to add support for them. Tests run okay in single-threaded, I'm pushing it here to run full tests and check I didn't break the threaded case.

I'm pushing this now because making this work saves adding a load of threading checks in python (this currently breaks single-threaded python i.e. emscripten).
* GitHub Issue: #41190

Lead-authored-by: Joe Marshall <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
@westonpace
Copy link
Member

Issue resolved by pull request 41125
#41125

@westonpace westonpace added this to the 17.0.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemarshall joemarshall

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@joemarshall @westonpace