Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] [Benchmarking] JavaScript benchmarks don't work on Amazon Linux #41015

Closed
austin3dickey opened this issue Apr 4, 2024 · 0 comments · Fixed by #41031
Closed

[JS] [Benchmarking] JavaScript benchmarks don't work on Amazon Linux #41015

austin3dickey opened this issue Apr 4, 2024 · 0 comments · Fixed by #41031
Assignees
@austin3dickey
Labels
Component: Benchmarking Component: JavaScript Type: bug
Milestone
16.0.0

Comments

@austin3dickey
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Amazon Linux, which is Fedora-based, does not have the -S option for the env command. So after

was merged, we cannot run yarn perf on EC2 instances, due to this shebang:

arrow/js/perf/index.ts

Line 1 in 72d20ad

#! /usr/bin/env -S node --no-warnings --loader ts-node/esm/transpile-only

Component(s)

Benchmarking, JavaScript
austin3dickey added a commit to austin3dickey/arrow that referenced this issue Apr 5, 2024
@austin3dickey
apacheGH-41015: allow JS benchmarks to run more portably
e5f6c93
@austin3dickey austin3dickey mentioned this issue Apr 5, 2024
Merged
domoritz pushed a commit that referenced this issue Apr 5, 2024
@austin3dickey
GH-41015: [JS] [Benchmarking] allow JS benchmarks to run more portably (
02bc653 
#41031)
@domoritz domoritz added this to the 16.0.0 milestone Apr 18, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@austin3dickey @tolleybot
apacheGH-41015: [JS] [Benchmarking] allow JS benchmarks to run more p…
0a18b48 
…ortably (apache#41031)
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@austin3dickey @vibhatha
apacheGH-41015: [JS] [Benchmarking] allow JS benchmarks to run more p…
e63c266 
…ortably (apache#41031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austin3dickey austin3dickey

Labels
Component: Benchmarking Component: JavaScript Type: bug
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-41015: [JS] [Benchmarking] allow JS benchmarks to run more portably austin3dickey/arrow
2 participants
@domoritz @austin3dickey