[C++][Gandiva] Function "LIKE" does not always work correctly when the string contains \n. #40968
Comments
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Apr 3, 2024
xxlaykxx
added a commit
to bookingnizer/arrow-apache
that referenced
this issue
Apr 9, 2024
kou
pushed a commit
that referenced
this issue
Apr 12, 2024
…unction (#40970) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: #40968 Lead-authored-by: Ivan Chesnov <[email protected]> Co-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
Issue resolved by pull request 40970 |
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this issue
Apr 12, 2024
…Like function (apache#40970) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Co-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
added a commit
to dremio/arrow
that referenced
this issue
Apr 12, 2024
…Like function (apache#40970) (#68) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
Apr 15, 2024
…Like function (apache#40970) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Co-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 2, 2024
…Like function (apache#40970) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Co-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
…Like function (apache#40970) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Co-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this issue
Jul 9, 2024
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this issue
Jul 9, 2024
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this issue
Jul 10, 2024
…Like function (apache#40970) (dremio#68) Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. added flag set_dot_nl(true) to LikeHolder add unit tests. Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this issue
Jul 11, 2024
…Like function (apache#40970) (dremio#68) Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. added flag set_dot_nl(true) to LikeHolder add unit tests. Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
xxlaykxx
added a commit
to dremio/arrow
that referenced
this issue
Jul 11, 2024
…Like f… (#78) * apacheGH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like function * apacheGH-43119: [CI][Packaging] Update manylinux 2014 CentOS repos that have been deprecated (apache#43121) ### Rationale for this change Jobs are failing to find mirrorlist.centos.org ### What changes are included in this PR? Updating repos based on solution from: apache#43119 (comment) ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: apache#43119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]> --------- Signed-off-by: Raúl Cumplido <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>
xxlaykxx
added a commit
to dremio/arrow
that referenced
this issue
Jul 12, 2024
…Like f (#80) * apacheGH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like function (apache#40970) (#68) Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. added flag set_dot_nl(true) to LikeHolder add unit tests. Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]> * apacheGH-43119: [CI][Packaging] Update manylinux 2014 CentOS repos that have been deprecated (apache#43121) Jobs are failing to find mirrorlist.centos.org Updating repos based on solution from: apache#43119 (comment) Via archery No * GitHub Issue: apache#43119 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]> --------- Signed-off-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]>
lriggs
pushed a commit
to lriggs/arrow
that referenced
this issue
Sep 6, 2024
…Like function (apache#40970) (dremio#68) ### Rationale for this change Gandiva function "LIKE" does not always work correctly when the string contains \n. String value: `[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]` Pattern '%Space1%' nor '%Space1.%' do not match. ### What changes are included in this PR? added flag set_dot_nl(true) to LikeHolder ### Are these changes tested? add unit tests. ### Are there any user-facing changes? Yes **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#40968 Lead-authored-by: Ivan Chesnov <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Gandiva function "LIKE" does not always work correctly when the string contains \n.
String value:
Pattern '%Space1%' or '%Space1.%' - not match.
Need to set set_dot_nl(true); to RE2::Options to handle this case.
Component(s)
C++ - Gandiva
The text was updated successfully, but these errors were encountered: