Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add benchmark for ToTensor conversions #40357

Closed
Tracked by #40058
AlenkaF opened this issue Mar 5, 2024 · 1 comment
Closed
Tracked by #40058

[C++] Add benchmark for ToTensor conversions #40357

AlenkaF opened this issue Mar 5, 2024 · 1 comment
Assignees
@AlenkaF
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Mar 5, 2024

Describe the enhancement requested

We should add benchmarks to be sure not to cause regressions while working on additional implementations of RecordBatch::ToTensor and Table::ToTensor.

The first step is to create a benchmark file with a basic benchmark for a simple uniform case of RecordBatch to Tensor conversion (all fields same type, no missing values). With follow-up features being added we should also add more cases to this benchmark file.

Component(s)

C++
@AlenkaF AlenkaF self-assigned this Mar 5, 2024
@AlenkaF AlenkaF mentioned this issue Mar 5, 2024
Open
12 tasks
@github-actions github-actions bot mentioned this issue Mar 5, 2024
Merged
jorisvandenbossche added a commit that referenced this issue Mar 26, 2024
@AlenkaF @jorisvandenbossche
GH-40357: [C++] Add benchmark for ToTensor conversions (#40358)
fc87fd7 
### Rationale for this change

We should add benchmarks to be sure not to cause regressions while working on additional implementations of `RecordBatch::ToTensor` and `Table::ToTensor`.

### What changes are included in this PR?

New `cpp/src/arrow/to_tensor_benchmark.cc file`.
* GitHub Issue: #40357

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Mar 26, 2024
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 40358
#40358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@jorisvandenbossche @AlenkaF