Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add TensorFromJSON helper function #40297

Closed
Tracked by #40058
AlenkaF opened this issue Feb 29, 2024 · 2 comments
Closed
Tracked by #40058

[C++] Add TensorFromJSON helper function #40297

AlenkaF opened this issue Feb 29, 2024 · 2 comments
Assignees
@AlenkaF
Labels
Component: C++ good-first-issue Type: enhancement

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Feb 29, 2024

Describe the enhancement requested

To make tests easier to write and read, we should create a TensorFromJSON() helper function. See #40064 (comment)

Component(s)

C++
@AlenkaF AlenkaF mentioned this issue Feb 29, 2024
Merged
@rok
Copy link
Member

rok commented Feb 29, 2024

It'd be nice to also be able to provide strides or dimension permutation as input.

@AlenkaF AlenkaF mentioned this issue Mar 5, 2024
Open
12 tasks
@AlenkaF AlenkaF self-assigned this Mar 5, 2024
@github-actions github-actions bot mentioned this issue Mar 5, 2024
Merged
AlenkaF added a commit that referenced this issue Mar 14, 2024
@AlenkaF @rok
GH-40297: [C++] Add TensorFromJSON helper function (#40365)
bad7b1a 
### Rationale for this change

To make tests easier to write and read, we should create a `TensorFromJSON()` helper function.

* GitHub Issue: #40297

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Rok Mihevc <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 26, 2024

Issue resolved by pull request #40365

@AlenkaF AlenkaF closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: C++ good-first-issue Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rok @AlenkaF