[Python] Disable C line generation in Cython tracebacks #40236
Comments
pitrou
added a commit
that referenced
this issue
Feb 26, 2024
#40225) ### Rationale for this change We're getting timeouts (on AppVeyor) and very long compilation times (on GHA wheel builds) for `lib.cpp`, a Cython-generated C++ file. Examination suggests that `lib.cpp` is more than 300 thousand lines long, and we can hypothesize that this can blow up available memory on some machines and compilers. ### What changes are included in this PR? Disable a not really useful (and undocumented) Cython feature to make C++ code slightly easier to compile. ### Are these changes tested? Yes. This solves, at least temporarily, the timeout issues on AppVeyor and makes the wheel builds much faster (down to ~35 minutes for the wheel build step, instead of 3 hours). ### Are there any user-facing changes? No. * GitHub Issue: #40236 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
Issue resolved by pull request 40225 |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
…cebacks (apache#40225) ### Rationale for this change We're getting timeouts (on AppVeyor) and very long compilation times (on GHA wheel builds) for `lib.cpp`, a Cython-generated C++ file. Examination suggests that `lib.cpp` is more than 300 thousand lines long, and we can hypothesize that this can blow up available memory on some machines and compilers. ### What changes are included in this PR? Disable a not really useful (and undocumented) Cython feature to make C++ code slightly easier to compile. ### Are these changes tested? Yes. This solves, at least temporarily, the timeout issues on AppVeyor and makes the wheel builds much faster (down to ~35 minutes for the wheel build step, instead of 3 hours). ### Are there any user-facing changes? No. * GitHub Issue: apache#40236 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…cebacks (apache#40225) ### Rationale for this change We're getting timeouts (on AppVeyor) and very long compilation times (on GHA wheel builds) for `lib.cpp`, a Cython-generated C++ file. Examination suggests that `lib.cpp` is more than 300 thousand lines long, and we can hypothesize that this can blow up available memory on some machines and compilers. ### What changes are included in this PR? Disable a not really useful (and undocumented) Cython feature to make C++ code slightly easier to compile. ### Are these changes tested? Yes. This solves, at least temporarily, the timeout issues on AppVeyor and makes the wheel builds much faster (down to ~35 minutes for the wheel build step, instead of 3 hours). ### Are there any user-facing changes? No. * GitHub Issue: apache#40236 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Disabling said option can make compilation of Cython-generated C++ sources slightly easier.
See cython/cython#4425 (comment)
Component(s)
Python
The text was updated successfully, but these errors were encountered: