Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Expose force_virtual_addressing in PyArrow #39779

Closed
pitrou opened this issue Jan 24, 2024 · 3 comments · Fixed by #39819
Closed

[Python] Expose force_virtual_addressing in PyArrow #39779

pitrou opened this issue Jan 24, 2024 · 3 comments · Fixed by #39819
Assignees
@teihenn
Labels
Component: Python good-first-issue Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jan 24, 2024

Describe the enhancement requested

In #36827 we added the force_virtual_addressing option to the S3 implementation in Arrow C++. It should now be exposed to Python users.

Component(s)

Python
@pitrou
Copy link
Member Author

pitrou commented Jan 24, 2024

cc @AlenkaF @jorisvandenbossche

@teihenn
Copy link
Contributor

teihenn commented Jan 27, 2024

@pitrou
I'm interested in working on this issue. Would that be okay?
It seems that making changes to _s3fs.pyx would be the way to go.

@teihenn teihenn mentioned this issue Jan 27, 2024
Merged
@teihenn
Copy link
Contributor

teihenn commented Jan 27, 2024

@pitrou
I've created a PR. If you find any mistakes or anything missing, please let me know. Thank you.

jorisvandenbossche pushed a commit that referenced this issue Feb 1, 2024
@teihenn
GH-39779: [Python] Expose force_virtual_addressing in PyArrow (#39819)
3d45ac9 
### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: #39779

Authored-by: yo1956 <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Feb 1, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@teihenn @dgreiss
apacheGH-39779: [Python] Expose force_virtual_addressing in PyArrow (a…
4e2e49c 
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@teihenn @zanmato1984
apacheGH-39779: [Python] Expose force_virtual_addressing in PyArrow (a…
a661b67 
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@teihenn @thisisnic
apacheGH-39779: [Python] Expose force_virtual_addressing in PyArrow (a…
6feecb5 
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche mentioned this issue Mar 13, 2024
Closed
@helmiazizm helmiazizm mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teihenn teihenn

Labels
Component: Python good-first-issue Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39779: [Python] Expose force_virtual_addressing in PyArrow teihenn/arrow
3 participants
@jorisvandenbossche @pitrou @teihenn