Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Allow passing in the Type for the MapArray.from_arrays #39515

Closed
Fokko opened this issue Jan 8, 2024 · 0 comments · Fixed by #39516
Closed

[Python] Allow passing in the Type for the MapArray.from_arrays #39515

Fokko opened this issue Jan 8, 2024 · 0 comments · Fixed by #39516
Assignees
@Fokko
Labels
Component: Python Type: enhancement
Milestone
15.0.0

Comments

@Fokko
Copy link
Contributor

Fokko commented Jan 8, 2024

Describe the enhancement requested

Similar to ListArray.from_arrays(self, offsets, values, DataType_type=None, MemoryPool_pool=None, mask=None)

Component(s)

Python
@Fokko Fokko changed the title Allow passing in the Type for the MapArray.from_arrays [PYTHON] Allow passing in the Type for the MapArray.from_arrays Jan 8, 2024
Fokko added a commit to Fokko/arrow that referenced this issue Jan 8, 2024
@Fokko
apacheGH-39515: [PYTHON] Pass in type to MapType.from_arrays
805ff9e
@github-actions github-actions bot mentioned this issue Jan 8, 2024
Merged
Fokko added a commit to Fokko/arrow that referenced this issue Jan 8, 2024
@Fokko
apacheGH-39515: [PYTHON] Pass in type to MapType.from_arrays
3373732
Fokko added a commit to Fokko/arrow that referenced this issue Jan 8, 2024
@Fokko
apacheGH-39515: [PYTHON] Pass in type to MapType.from_arrays
d1a52f3
@kou kou changed the title [PYTHON] Allow passing in the Type for the MapArray.from_arrays [Python] Allow passing in the Type for the MapArray.from_arrays Jan 9, 2024
@ianmcook ianmcook added this to the 15.0.0 milestone Jan 9, 2024
AlenkaF pushed a commit that referenced this issue Jan 10, 2024
@Fokko
GH-39515: [Python] Pass in type to MapType.from_arrays (#39516)
07a4655 
### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: #39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
raulcd pushed a commit that referenced this issue Jan 12, 2024
@Fokko @raulcd
GH-39515: [Python] Pass in type to MapType.from_arrays (#39516)
6a1044f 
### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: #39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@Fokko @clayburn
apacheGH-39515: [Python] Pass in type to MapType.from_arrays (apach…
9754f54 
…e#39516)

### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: apache#39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Fokko @dgreiss
apacheGH-39515: [Python] Pass in type to MapType.from_arrays (apach…
e8c543b 
…e#39516)

### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: apache#39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@Fokko @zanmato1984
apacheGH-39515: [Python] Pass in type to MapType.from_arrays (apach…
b5d4889 
…e#39516)

### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: apache#39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@Fokko @thisisnic
apacheGH-39515: [Python] Pass in type to MapType.from_arrays (apach…
695b0df 
…e#39516)

### Rationale for this change

For Iceberg we want to add metadata type the type (the field-id), therefore we need to pass in the type analog to what we do for `ListArray.from_arrays(self, offsets, values, DataType type=None, MemoryPool pool=None, mask=None)`.

### What changes are included in this PR?

Updated a keyword argument for the `type`, and make sure that the the static method to create the MapType is exposed from the cpp side.

### Are these changes tested?

I've added a simple test.

### Are there any user-facing changes?

* Closes: apache#39515

Authored-by: Fokko Driesprong <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fokko Fokko

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39515: [Python] Pass in type to MapType.from_arrays Fokko/arrow
2 participants
@ianmcook @Fokko