Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Azure CLI authentation #39344

Closed
Tom-Newton opened this issue Dec 21, 2023 · 6 comments
Closed

[C++][FS][Azure] Azure CLI authentation #39344

Tom-Newton opened this issue Dec 21, 2023 · 6 comments
Assignees
@Tom-Newton
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Child of #38598

Add support for Azure CLI auth. Should work on any system where you have run az login.

https://github.com/Azure/azure-sdk-for-cpp/blob/main/sdk/identity/azure-identity/src/azure_cli_credential.cpp

Component(s)

C++
@Tom-Newton Tom-Newton mentioned this issue Dec 21, 2023
Closed
1 task
@kou kou mentioned this issue Dec 22, 2023
Closed
@felipecrv
Copy link
Contributor

Note: this auth method is part of the default auth chain of the Azure SDK which is already available either implicitly of via AzureOptions::ConfigureDefaultCredential().

@kou
Copy link
Member

kou commented Jan 9, 2024

Can we close this?

@felipecrv
Copy link
Contributor

Can we close this?

What you think @Tom-Newton? Is there value in explicitly requesting CLI authentication instead of getting it from default behavior?

@Tom-Newton
Copy link
Contributor Author

I wouldn't close it. Probably this provides quite a small benefit, but a benefit nonetheless and I think it's very easy for us to implement this.

There have been lots of times I've wanted to use some tool, only to find Azure Auth options are lacking, so I'm keen to be comprehensive here.

This was referenced Apr 21, 2024
Merged
Open
@Tom-Newton
Copy link
Contributor Author

take

@github-actions github-actions bot mentioned this issue Jun 5, 2024
Merged
kou pushed a commit that referenced this issue Jun 10, 2024
@Tom-Newton
GH-39344: [C++][FS][Azure] Support azure cli auth (#41976)
f0a6f49 
### Rationale for this change
Maybe be useful to support explicit environment credential (currently environment credential can be used as part of the Azure default credential flow).

### What changes are included in this PR?
Create `ConfigureCLICredential`. Add it to FromUri

### Are these changes tested?
There are new unittests but no integration tests that we can actually authenticate successfully. We are relying on the Azure C++ SDK to abstracting that away.

### Are there any user-facing changes?
Explicit CLI auth is now supported

* GitHub Issue: #39344

Authored-by: Thomas Newton <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 17.0.0 milestone Jun 10, 2024
@kou
Copy link
Member

kou commented Jun 10, 2024

Issue resolved by pull request 41976
#41976

@kou kou closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@kou @felipecrv @Tom-Newton