Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Managed Identity authentication #39320

Closed
Tom-Newton opened this issue Dec 20, 2023 · 1 comment · Fixed by #39321
Closed

[C++][FS][Azure] Managed Identity authentication #39320

Tom-Newton opened this issue Dec 20, 2023 · 1 comment · Fixed by #39321
Assignees
@Tom-Newton
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Child of #38598

Add support for using Managed Identity. This auth method is only available when running on Azure VMs.

https://github.com/Azure/azure-sdk-for-cpp/blob/main/sdk/identity/azure-identity/src/managed_identity_source.cpp

Component(s)

C++
@Tom-Newton
Copy link
Contributor Author

take

This was referenced Dec 20, 2023
Closed
Merged
@kou kou mentioned this issue Dec 21, 2023
Closed
felipecrv pushed a commit that referenced this issue Dec 23, 2023
@Tom-Newton
GH-39320: [C++][FS][Azure] Add managed identity auth configuration (#…
d519544 
…39321)

### Rationale for this change
Workload identity is a useful Azure authentication method. Also I failed to set the account_name correctly for a bunch of auths (I think this got lost in a rebase then I copy pasted the broken code). 

### What changes are included in this PR?
- Make filesystem initialisation fail if `account_name_.empty()`. This prevents the account name configuration bug we had. Also added a test asserting that filesystem initialization fails in this case. 
- Remove account name configuration on all auth configs, in favour of setting in separately from the auth configuration. 
- Implement `AzureOptions::ConfigureManagedIdentityCredential`

### Are these changes tested?
Added a simple test initialising a filesystem using `ConfigureManagedIdentityCredential`. This is not the most comprehensive test but its the same as what we agreed on for #39263. 

### Are there any user-facing changes?
Managed identity authentication is now supported. 

* Closes: #39320

Authored-by: Thomas Newton <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
@felipecrv felipecrv added this to the 15.0.0 milestone Dec 23, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@Tom-Newton @clayburn
apacheGH-39320: [C++][FS][Azure] Add managed identity auth configurat…
f281041 
…ion (apache#39321)

### Rationale for this change
Workload identity is a useful Azure authentication method. Also I failed to set the account_name correctly for a bunch of auths (I think this got lost in a rebase then I copy pasted the broken code). 

### What changes are included in this PR?
- Make filesystem initialisation fail if `account_name_.empty()`. This prevents the account name configuration bug we had. Also added a test asserting that filesystem initialization fails in this case. 
- Remove account name configuration on all auth configs, in favour of setting in separately from the auth configuration. 
- Implement `AzureOptions::ConfigureManagedIdentityCredential`

### Are these changes tested?
Added a simple test initialising a filesystem using `ConfigureManagedIdentityCredential`. This is not the most comprehensive test but its the same as what we agreed on for apache#39263. 

### Are there any user-facing changes?
Managed identity authentication is now supported. 

* Closes: apache#39320

Authored-by: Thomas Newton <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Tom-Newton @dgreiss
apacheGH-39320: [C++][FS][Azure] Add managed identity auth configurat…
8f1a6a2 
…ion (apache#39321)

### Rationale for this change
Workload identity is a useful Azure authentication method. Also I failed to set the account_name correctly for a bunch of auths (I think this got lost in a rebase then I copy pasted the broken code). 

### What changes are included in this PR?
- Make filesystem initialisation fail if `account_name_.empty()`. This prevents the account name configuration bug we had. Also added a test asserting that filesystem initialization fails in this case. 
- Remove account name configuration on all auth configs, in favour of setting in separately from the auth configuration. 
- Implement `AzureOptions::ConfigureManagedIdentityCredential`

### Are these changes tested?
Added a simple test initialising a filesystem using `ConfigureManagedIdentityCredential`. This is not the most comprehensive test but its the same as what we agreed on for apache#39263. 

### Are there any user-facing changes?
Managed identity authentication is now supported. 

* Closes: apache#39320

Authored-by: Thomas Newton <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39320: [C++][FS][Azure] Add managed identity auth configuration Tom-Newton/arrow
2 participants
@felipecrv @Tom-Newton