Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Gandiva] Refactor function holder to return arrow Result #38920

Closed
niyue opened this issue Nov 28, 2023 · 0 comments · Fixed by #38873
Closed

[C++][Gandiva] Refactor function holder to return arrow Result #38920

niyue opened this issue Nov 28, 2023 · 0 comments · Fixed by #38873
Assignees
@niyue
Labels
Component: C++ - Gandiva Type: enhancement
Milestone
15.0.0

Comments

@niyue
Copy link
Contributor

niyue commented Nov 28, 2023

Describe the enhancement requested

Gandiva FunctionHolder classes currently use output parameters to return the holder function, and it can be refactored to return arrow::Result instead of using output parameters, and this tries to address the follow up task mentioned in #38632 (comment) and makes the code slightly simpler

Component(s)

C++ - Gandiva
@niyue niyue mentioned this issue Nov 28, 2023
Merged
@kou kou changed the title [C++][Gandiva] Refactor gandiva function holder to return arrow Result [C++][Gandiva] Refactor function holder to return arrow Result Nov 29, 2023
pitrou pushed a commit that referenced this issue Nov 29, 2023
@niyue
GH-38920: [C++][Gandiva] Refactor function holder to return arrow Res…
6f497ec 
…ult (#38873)

### Rationale for this change
* This PR tries to make Gandiva `FunctionHolder` classes to return `arrow::Result` instead of using output parameters, and this tries to address the follow up task mentioned in #38632 (comment) and makes the code slightly simpler

### What changes are included in this PR?
* A refactoring task to return `arrow::Result` in Gandiva FunctionHolder classes

### Are these changes tested?
It should be covered by existing unit tests.

### Are there any user-facing changes?
No
* Closes: #38920

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 15.0.0 milestone Nov 29, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@niyue @dgreiss
apacheGH-38920: [C++][Gandiva] Refactor function holder to return arr…
83e2f0b 
…ow Result (apache#38873)

### Rationale for this change
* This PR tries to make Gandiva `FunctionHolder` classes to return `arrow::Result` instead of using output parameters, and this tries to address the follow up task mentioned in apache#38632 (comment) and makes the code slightly simpler

### What changes are included in this PR?
* A refactoring task to return `arrow::Result` in Gandiva FunctionHolder classes

### Are these changes tested?
It should be covered by existing unit tests.

### Are there any user-facing changes?
No
* Closes: apache#38920

Authored-by: Yue Ni <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niyue niyue

Labels
Component: C++ - Gandiva Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38920: [C++][Gandiva] Refactor function holder to return arrow Result niyue/arrow
2 participants
@niyue @pitrou