Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Failed to build with OpenSSL 1.1 #38378

Closed
kou opened this issue Oct 20, 2023 · 0 comments · Fixed by #38379
Closed

[C++][Parquet] Failed to build with OpenSSL 1.1 #38378

kou opened this issue Oct 20, 2023 · 0 comments · Fixed by #38379
Assignees
@kou
Labels
Component: C++ Component: Parquet Type: bug
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Oct 20, 2023

Describe the bug, including details regarding any error messages, version, and platform.

It's caused by #38306.

centos-7-amd64:

https://github.com/ursacomputing/crossbow/actions/runs/6571980068/job/17852177717#step:8:3895

cd /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/src/parquet && /opt/rh/devtoolset-11/root/usr/bin/c++  -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_DYN_LINK -DHAVE_INTTYPES_H -DHAVE_NETDB_H -DHAVE_NETINET_IN_H -DPARQUET_EXPORTING -DPARQUET_THRIFT_VERSION_MAJOR=0 -DPARQUET_THRIFT_VERSION_MINOR=16 -DUTF8PROC_STATIC -I/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/src -I/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src -I/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/generated -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/thirdparty/flatbuffers/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/thirdparty/hadoop/include -isystem /usr/include/boost169 -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/orc_ep-install/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/protobuf_ep-install/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/utf8proc_ep-install/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/re2_ep-install/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/xsimd_ep/src/xsimd_ep-install/include -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/jemalloc_ep-prefix/src -isystem /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/build/thrift_ep-install/include  -Wno-noexcept-type -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches   -m64 -mtune=generic -fdiagnostics-color=always  -Wall -fno-semantic-interposition -msse4.2  -DNDEBUG -ftree-vectorize  -fPIC   -pthread -std=c++17 -o CMakeFiles/parquet_objlib.dir/encryption/crypto_factory.cc.o -c /root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/parquet/encryption/crypto_factory.cc
/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/parquet/encryption/openssl_internal.cc: In function 'void parquet::encryption::openssl::EnsureInitialized()':
/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/parquet/encryption/openssl_internal.cc:28:28: error: 'OPENSSL_INIT_ENGINE_ALL_BUILTIN' was not declared in this scope
   28 |   if (!OPENSSL_init_crypto(OPENSSL_INIT_ENGINE_ALL_BUILTIN | OPENSSL_INIT_ADD_ALL_CIPHERS,
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/parquet/encryption/openssl_internal.cc:28:62: error: 'OPENSSL_INIT_ADD_ALL_CIPHERS' was not declared in this scope; did you mean 'OPENSSL_NO_WEAK_SSL_CIPHERS'?
   28 |   if (!OPENSSL_init_crypto(OPENSSL_INIT_ENGINE_ALL_BUILTIN | OPENSSL_INIT_ADD_ALL_CIPHERS,
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                              OPENSSL_NO_WEAK_SSL_CIPHERS
/root/rpmbuild/BUILD/apache-arrow-14.0.0.dev366/cpp/src/parquet/encryption/openssl_internal.cc:28:8: error: 'OPENSSL_init_crypto' was not declared in this scope
   28 |   if (!OPENSSL_init_crypto(OPENSSL_INIT_ENGINE_ALL_BUILTIN | OPENSSL_INIT_ADD_ALL_CIPHERS,
      |        ^~~~~~~~~~~~~~~~~~~
make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/build.make:554: src/parquet/CMakeFiles/parquet_objlib.dir/encryption/openssl_internal.cc.o] Error 1

Component(s)

C++, Parquet
@kou kou added the Type: bug label Oct 20, 2023
kou added a commit to kou/arrow that referenced this issue Oct 20, 2023
@kou
apacheGH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly wi…
d7be15c 
…th OpenSSL 1.1
@github-actions github-actions bot mentioned this issue Oct 20, 2023
Merged
kou added a commit that referenced this issue Oct 27, 2023
@kou
GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with Ope…
6e6fd0a 
…nSSL 1.1 (#38379)

### Rationale for this change

This explicit initialization is for Valgrind and OpenSSL 1.1 will be unsupported eventually. So we can disable this explicit initialization for OpenSSL 1.1. 

### What changes are included in this PR?

Disable the explicit initialization with OpenSSL 1.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38378

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 15.0.0 milestone Oct 27, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly wi…
d5bb3dd 
…th OpenSSL 1.1 (apache#38379)

### Rationale for this change

This explicit initialization is for Valgrind and OpenSSL 1.1 will be unsupported eventually. So we can disable this explicit initialization for OpenSSL 1.1. 

### What changes are included in this PR?

Disable the explicit initialization with OpenSSL 1.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38378

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly wi…
cd333d6 
…th OpenSSL 1.1 (apache#38379)

### Rationale for this change

This explicit initialization is for Valgrind and OpenSSL 1.1 will be unsupported eventually. So we can disable this explicit initialization for OpenSSL 1.1. 

### What changes are included in this PR?

Disable the explicit initialization with OpenSSL 1.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38378

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Parquet Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38378: [C++][Parquet] Don't initialize OpenSSL explicitly with OpenSSL 1.1 kou/arrow
1 participant
@kou