Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Implement IReadOnlyList<T?> on scalar arrays #38348

Closed
CurtHagenlocher opened this issue Oct 19, 2023 · 0 comments · Fixed by #38680
Closed

[C#] Implement IReadOnlyList<T?> on scalar arrays #38348

CurtHagenlocher opened this issue Oct 19, 2023 · 0 comments · Fixed by #38680
Labels
Component: C# Type: enhancement
Milestone
15.0.0

Comments

@CurtHagenlocher
Copy link
Contributor

Describe the enhancement requested

Arrow arrays of scalar type T implement the same semantic contract as IReadOnlyList<T?>. If they were to implement this contract then they could be used in existing code which expects arrays of that type. If they were also to implement ICollection<T?>, it would optimize their use with LINQ (pre-.NET 9), allowing for e.g. fast conversion to lists via the extension method ToList().

This change would to some extent supersede and/or resolve #23892, #35199 and #37359.

Component(s)

C#
@github-actions github-actions bot mentioned this issue Nov 11, 2023
Merged
@voidstar69 voidstar69 mentioned this issue Nov 13, 2023
Closed
CurtHagenlocher pushed a commit that referenced this issue Nov 19, 2023
@voidstar69
GH-38348: [C#] Make PrimitiveArray<T> support IReadOnlyList<T?> (#38680)
96e62d8 
### What changes are included in this PR?

Make Arrow arrays of scalar type T implement the same semantic contract as IReadOnlyList<T?>.
Note that this PR does not include similar support for ICollection<T?>. I could add that support in this PR or a future PR.

### Are these changes tested?

This PR includes unit tests of the implemented IReadOnlyList<T?> methods.
* Closes: #38348

Authored-by: voidstar69 <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
@CurtHagenlocher CurtHagenlocher added this to the 15.0.0 milestone Nov 19, 2023
@CurtHagenlocher CurtHagenlocher changed the title [C#] Implement IReadOnlyList<T?> and ICollection<T?> on scalar arrays [C#] Implement IReadOnlyList<T?> on scalar arrays Jan 15, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@voidstar69 @dgreiss
apacheGH-38348: [C#] Make PrimitiveArray<T> support IReadOnlyList<T?> (…
0184ac0 
…apache#38680)

### What changes are included in this PR?

Make Arrow arrays of scalar type T implement the same semantic contract as IReadOnlyList<T?>.
Note that this PR does not include similar support for ICollection<T?>. I could add that support in this PR or a future PR.

### Are these changes tested?

This PR includes unit tests of the implemented IReadOnlyList<T?> methods.
* Closes: apache#38348

Authored-by: voidstar69 <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38348: [C#] Make PrimitiveArray<T> support IReadOnlyList<T?> voidstar69/arrow
1 participant
@CurtHagenlocher