Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] version_match should match the version from versions.json #38240

Closed
AlenkaF opened this issue Oct 12, 2023 · 2 comments · Fixed by #38241
Closed

[Docs] version_match should match the version from versions.json #38240

AlenkaF opened this issue Oct 12, 2023 · 2 comments · Fixed by #38241

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Oct 12, 2023

Describe the enhancement requested

To correctly display versions in the version switcher we need ro make sure version_match matches the version defined in versions.json.

Part of #37947

Component(s)

Documentation

@raulcd
Copy link
Member

raulcd commented Oct 16, 2023

@AlenkaF @jorisvandenbossche this is marked as 14.0.0, should this block the release?

@AlenkaF
Copy link
Member Author

AlenkaF commented Oct 16, 2023

It would be good to sort the version switcher text before the documentation is built and added to the arrow-site as I am not sure we can correct it later, if there will be a need to. But at the same time I wouldn't call it a blocker. Also I do not see a clear solution at this moment.

jorisvandenbossche pushed a commit that referenced this issue Oct 17, 2023
….json (#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: #38240

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
raulcd pushed a commit that referenced this issue Oct 17, 2023
….json (#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: #38240

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants