Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Minimal nightly builds are failing #38228

Closed
paleolimbot opened this issue Oct 12, 2023 · 0 comments · Fixed by #38229
Closed

[R] Minimal nightly builds are failing #38228

paleolimbot opened this issue Oct 12, 2023 · 0 comments · Fixed by #38229
Assignees
@paleolimbot
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone
14.0.0

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

These are failing because of an example that needs fencing in @examplesIf arrow_with_dataset().

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=55504&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181

❯ checking examples ... ERROR
  Running examples in ‘arrow-Ex.R’ failed
  The error most likely occurred in:
  
  > ### Name: csv_convert_options
  > ### Title: CSV Convert Options
  > ### Aliases: csv_convert_options
  > 
  > ### ** Examples
  > 
  > tf <- tempfile()
  > on.exit(unlink(tf))
  > writeLines("x\n1\nNULL\n2\nNA", tf)
  > read_csv_arrow(tf, convert_options = csv_convert_options(null_values = c("", "NA", "NULL")))
     x
  1  1
  2 NA
  3  2
  4 NA
  > open_csv_dataset(tf, convert_options = csv_convert_options(null_values = c("", "NA", "NULL")))
  Error: This build of the arrow package does not support Datasets
  Execution halted

Component(s)

R
@paleolimbot paleolimbot added the Priority: Blocker Marks a blocker for the release label Oct 12, 2023
@github-actions github-actions bot mentioned this issue Oct 12, 2023
Merged
paleolimbot added a commit that referenced this issue Oct 12, 2023
@paleolimbot
GH-38228: [R] Fence examples that need dataset with examplesIf (#38229
84a4ab1 
)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: #38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@paleolimbot paleolimbot added this to the 14.0.0 milestone Oct 12, 2023
llama90 pushed a commit to llama90/arrow that referenced this issue Oct 12, 2023
@paleolimbot @llama90
apacheGH-38228: [R] Fence examples that need dataset with examplesIf (
bb14b47 
apache#38229)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: apache#38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
raulcd pushed a commit that referenced this issue Oct 13, 2023
@paleolimbot @raulcd
GH-38228: [R] Fence examples that need dataset with examplesIf (#38229
e1c66c0 
)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: #38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@paleolimbot
apacheGH-38228: [R] Fence examples that need dataset with examplesIf (
e36273f 
apache#38229)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: apache#38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@paleolimbot @loicalleyne
apacheGH-38228: [R] Fence examples that need dataset with examplesIf (
aeb6b4f 
apache#38229)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: apache#38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-38228: [R] Fence examples that need dataset with examplesIf (
2b15140 
apache#38229)

### Rationale for this change

The minimal nightly build are failing with examples that won't run without the dataset feature

### What changes are included in this PR?

- Added `examplesIf` where needed
- Redocumented

### Are these changes tested?

Yes, by all R CMD check jobs

### Are there any user-facing changes?

No
* Closes: apache#38228

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38228: [R] Fence examples that need dataset with examplesIf paleolimbot/arrow
1 participant
@paleolimbot