Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use absolute path for external project's ar/ranlib #38063

Closed
kou opened this issue Oct 6, 2023 · 0 comments · Fixed by #38064
Closed

[C++] Use absolute path for external project's ar/ranlib #38063

kou opened this issue Oct 6, 2023 · 0 comments · Fixed by #38064
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Oct 6, 2023

Describe the enhancement requested

If we use relative path, CMake try using relative path from a build directory.

For example:

[31/34] Linking C static library libbrotlicommon-static.a
FAILED: libbrotlicommon-static.a 
: && /usr/bin/cmake -E rm -f libbrotlicommon-static.a && /bin/emar qc libbrotlicommon-static.a  CMakeFiles/brotlicommon-static.dir/c/common/constants.c.o CMakeFiles/brotlicommon-static.dir/c/common/context.c.o CMakeFiles/brotlicommon-static.dir/c/common/dictionary.c.o CMakeFiles/brotlicommon-static.dir/c/common/platform.c.o CMakeFiles/brotlicommon-static.dir/c/common/transform.c.o && cpp.build.emscripten/brotli_ep-prefix/src/brotli_ep-build/emranlib libbrotlicommon-static.a && :
/bin/sh: 1: cpp.build.emscripten/brotli_ep-prefix/src/brotli_ep-build/emranlib: not found

Component(s)

C++
kou added a commit to kou/arrow that referenced this issue Oct 6, 2023
@kou
apacheGH-38063: [C++] Use absolute path for external project's ar/ranlib
c0ac176
@github-actions github-actions bot mentioned this issue Oct 6, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Oct 8, 2023
@kou
apacheGH-38063: [C++] Use absolute path for external project's ar/ranlib
64c38a8
@kou kou closed this as completed in #38064 Oct 9, 2023
kou added a commit that referenced this issue Oct 9, 2023
@kou
GH-38063: [C++] Use absolute path for external project's ar/ranlib (#…
34eb21d 
…38064)

### Rationale for this change

If we use relative path, CMake try using relative path from a build directory.

### What changes are included in this PR?

Ensure using absolute path.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38063

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 14.0.0 milestone Oct 9, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@kou
apacheGH-38063: [C++] Use absolute path for external project's ar/ran…
946b0b9 
…lib (apache#38064)

### Rationale for this change

If we use relative path, CMake try using relative path from a build directory.

### What changes are included in this PR?

Ensure using absolute path.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38063

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-38063: [C++] Use absolute path for external project's ar/ran…
5b95a8e 
…lib (apache#38064)

### Rationale for this change

If we use relative path, CMake try using relative path from a build directory.

### What changes are included in this PR?

Ensure using absolute path.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38063

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38063: [C++] Use absolute path for external project's ar/ran…
e6e1e72 
…lib (apache#38064)

### Rationale for this change

If we use relative path, CMake try using relative path from a build directory.

### What changes are included in this PR?

Ensure using absolute path.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38063

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38063: [C++] Use absolute path for external project's ar/ranlib kou/arrow
1 participant
@kou