Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Enable full feature libarrow build as default on macOS #38043

Closed
2 tasks
assignUser opened this issue Oct 5, 2023 · 5 comments · Fixed by #38195
Closed
2 tasks

[R] Enable full feature libarrow build as default on macOS #38043

assignUser opened this issue Oct 5, 2023 · 5 comments · Fixed by #38195
Assignees
@assignUser
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: enhancement
Milestone
14.0.0

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

With the new build system added in #37923 the default macOS source build does not build with gcs/s3 (even if openssl and libcurl are available).

  • update r/configure/nixlibs.R and r/tools/build_arrow_static.sh to build as many features as possible on macos
  • take rosetta into account (no jemalloc see install-arrow.R)

Component(s)

R
@assignUser assignUser added Type: enhancement Priority: Blocker Marks a blocker for the release labels Oct 5, 2023
@assignUser assignUser added this to the 14.0.0 milestone Oct 5, 2023
@assignUser assignUser self-assigned this Oct 5, 2023
@jonkeane
Copy link
Member

This is a definite blocker for 14.0.0 yeah?

@raulcd
Copy link
Member

raulcd commented Oct 10, 2023

I was going to treat it as a blocker due to the label.

@github-actions github-actions bot mentioned this issue Oct 11, 2023
Merged
@paleolimbot
Copy link
Member

Unless we've changed direction, I think we're planning on submitting the release to CRAN with the "static downloading" approach (and only use this approach if we are asked to do so by CRAN). Under that logic, I think we can remove the Blocker status of this issue (but only if @assignUser confirms this!).

@assignUser
Copy link
Member Author

Eh, as the PR is basically done I'd prefer to get it merged... Just to be sure ^^

@paleolimbot
Copy link
Member

OK! (As long as we are not rushing the PR or holding up the release unnecessarily)

assignUser added a commit that referenced this issue Oct 13, 2023
@assignUser @paleolimbot @jonkeane
GH-38043: [R] Enable all features by default on macOS (#38195)
4bf777a 
### Rationale for this change

Previously GCS/S3 support would need to be explicitly enabled in source builds (when they are build without `NOT_CRAN`). As we want the macos binaries to be fully featured we should turn the features on when the dependencies exists. 

### What changes are included in this PR?

This PR enables this behavior for macOS only, on Linux setting `NOT_CRAN` or  `LIBARROW_MINIMAL=false` is still required.

### Are these changes tested?

Crossbow and locally (thanks @ paleolimbot )
* Closes: #38043

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
raulcd pushed a commit that referenced this issue Oct 13, 2023
@assignUser @paleolimbot
@jonkeane @raulcd
GH-38043: [R] Enable all features by default on macOS (#38195)
6cc8214 
### Rationale for this change

Previously GCS/S3 support would need to be explicitly enabled in source builds (when they are build without `NOT_CRAN`). As we want the macos binaries to be fully featured we should turn the features on when the dependencies exists. 

### What changes are included in this PR?

This PR enables this behavior for macOS only, on Linux setting `NOT_CRAN` or  `LIBARROW_MINIMAL=false` is still required.

### Are these changes tested?

Crossbow and locally (thanks @ paleolimbot )
* Closes: #38043

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@assignUser @paleolimbot @jonkeane
apacheGH-38043: [R] Enable all features by default on macOS (apache#3…
d238085 
…8195)

### Rationale for this change

Previously GCS/S3 support would need to be explicitly enabled in source builds (when they are build without `NOT_CRAN`). As we want the macos binaries to be fully featured we should turn the features on when the dependencies exists. 

### What changes are included in this PR?

This PR enables this behavior for macOS only, on Linux setting `NOT_CRAN` or  `LIBARROW_MINIMAL=false` is still required.

### Are these changes tested?

Crossbow and locally (thanks @ paleolimbot )
* Closes: apache#38043

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@assignUser @paleolimbot
@jonkeane @loicalleyne
apacheGH-38043: [R] Enable all features by default on macOS (apache#3…
673b0bb 
…8195)

### Rationale for this change

Previously GCS/S3 support would need to be explicitly enabled in source builds (when they are build without `NOT_CRAN`). As we want the macos binaries to be fully featured we should turn the features on when the dependencies exists. 

### What changes are included in this PR?

This PR enables this behavior for macOS only, on Linux setting `NOT_CRAN` or  `LIBARROW_MINIMAL=false` is still required.

### Are these changes tested?

Crossbow and locally (thanks @ paleolimbot )
* Closes: apache#38043

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@assignUser @paleolimbot
@jonkeane @dgreiss
apacheGH-38043: [R] Enable all features by default on macOS (apache#3…
af5bae9 
…8195)

### Rationale for this change

Previously GCS/S3 support would need to be explicitly enabled in source builds (when they are build without `NOT_CRAN`). As we want the macos binaries to be fully featured we should turn the features on when the dependencies exists. 

### What changes are included in this PR?

This PR enables this behavior for macOS only, on Linux setting `NOT_CRAN` or  `LIBARROW_MINIMAL=false` is still required.

### Are these changes tested?

Crossbow and locally (thanks @ paleolimbot )
* Closes: apache#38043

Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Dewey Dunnington <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: R Priority: Blocker Marks a blocker for the release Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38043: [R] Enable all features by default on macOS assignUser/arrow
4 participants
@raulcd @jonkeane @paleolimbot @assignUser