Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Option for $schema$code() to explicitly use package name #38033

Closed
orgadish opened this issue Oct 5, 2023 · 14 comments · Fixed by #38144
Closed

[R] Option for $schema$code() to explicitly use package name #38033

orgadish opened this issue Oct 5, 2023 · 14 comments · Fixed by #38144

Comments

@orgadish
Copy link
Contributor

orgadish commented Oct 5, 2023

Describe the enhancement requested

I am using arrow to write a package to help others interface with some data I have.

As such, I am using arrow::arrow_table(sample_data)$schema$code() to get an initial schema, copying it into the package, and then adjusting as necessary. However, in the package, I have to explicitly use arrow:: for each datatype. It would be great if there was an argument, e.g. code(include_package_name=FALSE) that could be enabled such that the output looks like:

arrow::schema(A = arrow::string(), ...)

instead of

schema(A = string(), ...)

Component(s)

R

@thisisnic thisisnic changed the title Option for $schema$code() to explicitly use package name [R] Option for $schema$code() to explicitly use package name Oct 5, 2023
@thisisnic
Copy link
Member

Thanks for the feature request @orgadish. Sounds good to me! Do you want to make a pull request? Happy to help with any bits you need guidance on.

@orgadish
Copy link
Contributor Author

orgadish commented Oct 9, 2023

@thisisnic I've created a PR for this, but have not been able to load the package in my local RStudio. I get the following errors:

Error in dyn.load(dll_copy_file) : 
  unable to load shared object '/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//RtmpFfA62h/pkgload127a31261e174/arrow.so':
  dlopen(/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//RtmpFfA62h/pkgload127a31261e174/arrow.so, 0x0006): symbol not found in flat namespace '__ZN5arrow12ArrayBuilder12AppendScalarERKNS_6ScalarEx'

(This is after running brew install apache-arrow --HEAD).

Any thoughts?

@thisisnic
Copy link
Member

It might be an issue with our nightly builds. Would you mind confirming which OS you're on?

@orgadish
Copy link
Contributor Author

orgadish commented Oct 9, 2023 via email

@thisisnic
Copy link
Member

@assignUser Any idea what that error message could be?

@thisisnic
Copy link
Member

@orgadish We're in the middle of a release (so folks are looking at other things) and also in the middle of refactoring our build system, and so the simplest option in the short term might be to try a source build if that's OK? Could you see if running devtools::load_all() works for you for loading the package? It might pause a while while it's building the C++ library, but subsequent calls to devtools::load_all() should be faster.

@orgadish
Copy link
Contributor Author

orgadish commented Oct 11, 2023 via email

@thisisnic
Copy link
Member

Ah, I see! Would you mind trying the instructions here for manually doing a source build? https://arrow.apache.org/docs/r/articles/developers/setup.html#r-and-c

@orgadish
Copy link
Contributor Author

orgadish commented Oct 11, 2023 via email

@amoeba
Copy link
Member

amoeba commented Oct 11, 2023

Hi @orgadish, sorry you've having issues. Could you try the following from an R repl and report back with the complete output?

Sys.setenv("ARROW_R_DEV"=TRUE) # This gives us more information
devtools::load_all()

@orgadish
Copy link
Contributor Author

@amoeba Here is the output using ARROW_RDEV=TRUE:

> Sys.setenv("ARROW_R_DEV"=TRUE) # This gives us more information
> 
> devtools::load_all()
ℹ Loading arrow
ℹ Re-compiling arrow (debug build)
── R CMD INSTALL ──────────────────────────────────────────────────────────────────────────
─  installing *source* package ‘arrow’ ...
   ** using staged installation
   *** Generating code with data-raw/codegen.R
   *** > 542 functions decorated with [[arrow|acero|dataset|substrait|parquet|s3|gcs|json::export]]
   *** > `src/arrowExports.cpp` not modified
   *** > `R/arrowExports.R` not modified
   *** Found libcurl and OpenSSL >= 3.0.0
   trying URL 'https://nightlies.apache.org/arrow/r/libarrow/bin/darwin-x86_64-openssl-3.0/arrow-13.0.0.9000.zip'
   Error in download.file(from_url, to_file, quiet = hush) : 
     cannot open URL 'https://nightlies.apache.org/arrow/r/libarrow/bin/darwin-x86_64-openssl-3.0/arrow-13.0.0.9000.zip'
   *** Downloading libarrow binary failed for version 13.0.0.9000 (darwin-x86_64-openssl-3.0)
       at https://nightlies.apache.org/arrow/r/libarrow/bin/darwin-x86_64-openssl-3.0/arrow-13.0.0.9000.zip
   *** Found local C++ source: '../cpp'
   *** Building libarrow from source
       For build options and troubleshooting, see the install guide:
       https://arrow.apache.org/docs/r/articles/install.html
   *** Building with MAKEFLAGS= -j2 
   **** cmake: /usr/local/bin/cmake
   **** pkg-config not installed, setting ARROW_DEPENDENCY_SOURCE=BUNDLED
   **** arrow with SOURCE_DIR='../cpp' BUILD_DIR='/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//Rtmp8N6ErB/file4a9f170eb101' DEST_DIR='libarrow/arrow-13.0.0.9000' CMAKE='/usr/local/bin/cmake' EXTRA_CMAKE_FLAGS='' CC='/usr/local/gfortran/bin/gcc -fopenmp' CXX='clang++ -arch x86_64 -std=gnu++17' LDFLAGS='-L/usr/local/gfortran/lib -Wl,-rpath,/usr/local/gfortran/lib' N_JOBS='2' ARROW_DEPENDENCY_SOURCE='BUNDLED' ARROW_S3='OFF' ARROW_GCS='OFF' 
   ++ pwd
   + : /Users/orgadish/Documents/GitHub/arrow/r
   + : ../cpp
   + : /var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//Rtmp8N6ErB/file4a9f170eb101
   + : libarrow/arrow-13.0.0.9000
   + : /usr/local/bin/cmake
   ++ cd ../cpp
   ++ pwd
   + SOURCE_DIR=/Users/orgadish/Documents/GitHub/arrow/cpp
   ++ mkdir -p libarrow/arrow-13.0.0.9000
   ++ cd libarrow/arrow-13.0.0.9000
   ++ pwd
   + DEST_DIR=/Users/orgadish/Documents/GitHub/arrow/r/libarrow/arrow-13.0.0.9000
   + '[' 2 = '' ']'
   + '[' '' '!=' '' ']'
   + '[' '' = false ']'
   + ARROW_DEFAULT_PARAM=OFF
   + case "$CXX" in
   + mkdir -p /var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//Rtmp8N6ErB/file4a9f170eb101
   + pushd /var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//Rtmp8N6ErB/file4a9f170eb101
   /var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T/Rtmp8N6ErB/file4a9f170eb101 ~/Documents/GitHub/arrow/r
   + /usr/local/bin/cmake -DARROW_BOOST_USE_SHARED=OFF -DARROW_BUILD_TESTS=OFF -DARROW_BUILD_SHARED=OFF -DARROW_BUILD_STATIC=ON -DARROW_ACERO=ON -DARROW_COMPUTE=ON -DARROW_CSV=ON -DARROW_DATASET=ON -DARROW_DEPENDENCY_SOURCE=BUNDLED -DAWSSDK_SOURCE= -DARROW_FILESYSTEM=ON -DARROW_GCS=OFF -DARROW_JEMALLOC=OFF -DARROW_MIMALLOC=ON -DARROW_JSON=ON -DARROW_PARQUET=ON -DARROW_S3=OFF -DARROW_WITH_BROTLI=OFF -DARROW_WITH_BZ2=OFF -DARROW_WITH_LZ4=ON -DARROW_WITH_RE2=ON -DARROW_WITH_SNAPPY=ON -DARROW_WITH_UTF8PROC=ON -DARROW_WITH_ZLIB=OFF -DARROW_WITH_ZSTD=OFF -DARROW_VERBOSE_THIRDPARTY_BUILD=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_DEBUG_MODE=OFF -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_INSTALL_PREFIX=/Users/orgadish/Documents/GitHub/arrow/r/libarrow/arrow-13.0.0.9000 -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_UNITY_BUILD=OFF -Dxsimd_SOURCE= -Dzstd_SOURCE= -G 'Unix Makefiles' /Users/orgadish/Documents/GitHub/arrow/cpp
   -- Building using CMake version: 3.27.7
   -- The C compiler identification is GNU 8.2.0
   -- The CXX compiler identification is AppleClang 14.0.3.14030022
   -- Checking whether C compiler has -isysroot
   -- Checking whether C compiler has -isysroot - yes
   -- Checking whether C compiler supports OSX deployment target flag
   -- Checking whether C compiler supports OSX deployment target flag - yes
   -- Detecting C compiler ABI info
   -- Detecting C compiler ABI info - done
   -- Check for working C compiler: /usr/local/gfortran/bin/gcc - skipped
   -- Detecting C compile features
   -- Detecting C compile features - done
   -- Detecting CXX compiler ABI info
   -- Detecting CXX compiler ABI info - done
   -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/clang++ - skipped
   -- Detecting CXX compile features
   -- Detecting CXX compile features - done
   -- Arrow version: 14.0.0 (full: '14.0.0-SNAPSHOT')
   -- Arrow SO version: 1400 (full: 1400.0.0)
   -- clang-tidy 14 not found
   -- clang-format found, but version did not match "clang-format version 14"
   -- clang-format 14 not found
   -- Could NOT find ClangTools (missing: CLANG_FORMAT_BIN CLANG_TIDY_BIN) 
   -- infer not found
   -- Found Python3: /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11 (found version "3.11.1") found components: Interpreter 
   -- Found cpplint executable at /Users/orgadish/Documents/GitHub/arrow/cpp/build-support/cpplint.py
   -- System processor: x86_64
   -- Performing Test CXX_SUPPORTS_SSE4_2
   -- Performing Test CXX_SUPPORTS_SSE4_2 - Success
   -- Performing Test CXX_SUPPORTS_AVX2
   -- Performing Test CXX_SUPPORTS_AVX2 - Success
   -- Performing Test CXX_SUPPORTS_AVX512
   -- Performing Test CXX_SUPPORTS_AVX512 - Success
   -- Arrow build warning level: PRODUCTION
   -- Build Type: RELEASE
   -- Performing Test CXX_LINKER_SUPPORTS_VERSION_SCRIPT
   -- Performing Test CXX_LINKER_SUPPORTS_VERSION_SCRIPT - Failed
   -- Using BUNDLED approach to find dependencies
   -- ARROW_ABSL_BUILD_VERSION: 20211102.0
   -- ARROW_ABSL_BUILD_SHA256_CHECKSUM: dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
   -- ARROW_AWS_C_AUTH_BUILD_VERSION: v0.6.22
   -- ARROW_AWS_C_AUTH_BUILD_SHA256_CHECKSUM: 691a6b4418afcd3dc141351b6ad33fccd8e3ff84df0e9e045b42295d284ee14c
   -- ARROW_AWS_C_CAL_BUILD_VERSION: v0.5.20
   -- ARROW_AWS_C_CAL_BUILD_SHA256_CHECKSUM: acc352359bd06f8597415c366cf4ec4f00d0b0da92d637039a73323dd55b6cd0
   -- ARROW_AWS_C_COMMON_BUILD_VERSION: v0.8.9
   -- ARROW_AWS_C_COMMON_BUILD_SHA256_CHECKSUM: 2f3fbaf7c38eae5a00e2a816d09b81177f93529ae8ba1b82dc8f31407565327a
   -- ARROW_AWS_C_COMPRESSION_BUILD_VERSION: v0.2.16
   -- ARROW_AWS_C_COMPRESSION_BUILD_SHA256_CHECKSUM: 044b1dbbca431a07bde8255ef9ec443c300fc60d4c9408d4b862f65e496687f4
   -- ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION: v0.2.18
   -- ARROW_AWS_C_EVENT_STREAM_BUILD_SHA256_CHECKSUM: 310ca617f713bf664e4c7485a3d42c1fb57813abd0107e49790d107def7cde4f
   -- ARROW_AWS_C_HTTP_BUILD_VERSION: v0.7.3
   -- ARROW_AWS_C_HTTP_BUILD_SHA256_CHECKSUM: 07e16c6bf5eba6f0dea96b6f55eae312a7c95b736f4d2e4a210000f45d8265ae
   -- ARROW_AWS_C_IO_BUILD_VERSION: v0.13.14
   -- ARROW_AWS_C_IO_BUILD_SHA256_CHECKSUM: 12b66510c3d9a4f7e9b714e9cfab2a5bf835f8b9ce2f909d20ae2a2128608c71
   -- ARROW_AWS_C_MQTT_BUILD_VERSION: v0.8.4
   -- ARROW_AWS_C_MQTT_BUILD_SHA256_CHECKSUM: 232eeac63e72883d460c686a09b98cdd811d24579affac47c5c3f696f956773f
   -- ARROW_AWS_C_S3_BUILD_VERSION: v0.2.3
   -- ARROW_AWS_C_S3_BUILD_SHA256_CHECKSUM: a00b3c9f319cd1c9aa2c3fa15098864df94b066dcba0deaccbb3caa952d902fe
   -- ARROW_AWS_C_SDKUTILS_BUILD_VERSION: v0.1.6
   -- ARROW_AWS_C_SDKUTILS_BUILD_SHA256_CHECKSUM: 8a2951344b2fb541eab1e9ca17c18a7fcbfd2aaff4cdd31d362d1fad96111b91
   -- ARROW_AWS_CHECKSUMS_BUILD_VERSION: v0.1.13
   -- ARROW_AWS_CHECKSUMS_BUILD_SHA256_CHECKSUM: 0f897686f1963253c5069a0e495b85c31635ba146cd3ac38cc2ea31eaf54694d
   -- ARROW_AWS_CRT_CPP_BUILD_VERSION: v0.18.16
   -- ARROW_AWS_CRT_CPP_BUILD_SHA256_CHECKSUM: 9e69bc1dc4b50871d1038aa9ff6ddeb4c9b28f7d6b5e5b1b69041ccf50a13483
   -- ARROW_AWS_LC_BUILD_VERSION: v1.3.0
   -- ARROW_AWS_LC_BUILD_SHA256_CHECKSUM: ae96a3567161552744fc0cae8b4d68ed88b1ec0f3d3c98700070115356da5a37
   -- ARROW_AWSSDK_BUILD_VERSION: 1.10.55
   -- ARROW_AWSSDK_BUILD_SHA256_CHECKSUM: 2d552fb1a84bef4a9b65e34aa7031851ed2aef5319e02cc6e4cb735c48aa30de
   -- ARROW_AZURE_SDK_BUILD_VERSION: azure-core_1.10.2
   -- ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM: 36557dae87de4cdd257d9b441d9a7f043290eae6666fb1065e0fa486ae3e58a0
   -- ARROW_BOOST_BUILD_VERSION: 1.81.0
   -- ARROW_BOOST_BUILD_SHA256_CHECKSUM: 9e0ffae35528c35f90468997bc8d99500bf179cbae355415a89a600c38e13574
   -- ARROW_BROTLI_BUILD_VERSION: v1.0.9
   -- ARROW_BROTLI_BUILD_SHA256_CHECKSUM: f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46
   -- ARROW_BZIP2_BUILD_VERSION: 1.0.8
   -- ARROW_BZIP2_BUILD_SHA256_CHECKSUM: ab5a03176ee106d3f0fa90e381da478ddae405918153cca248e682cd0c4a2269
   -- ARROW_CARES_BUILD_VERSION: 1.17.2
   -- ARROW_CARES_BUILD_SHA256_CHECKSUM: 4803c844ce20ce510ef0eb83f8ea41fa24ecaae9d280c468c582d2bb25b3913d
   -- ARROW_CRC32C_BUILD_VERSION: 1.1.2
   -- ARROW_CRC32C_BUILD_SHA256_CHECKSUM: ac07840513072b7fcebda6e821068aa04889018f24e10e46181068fb214d7e56
   -- ARROW_GBENCHMARK_BUILD_VERSION: v1.7.1
   -- ARROW_GBENCHMARK_BUILD_SHA256_CHECKSUM: 6430e4092653380d9dc4ccb45a1e2dc9259d581f4866dc0759713126056bc1d7
   -- ARROW_GFLAGS_BUILD_VERSION: v2.2.2
   -- ARROW_GFLAGS_BUILD_SHA256_CHECKSUM: 34af2f15cf7367513b352bdcd2493ab14ce43692d2dcd9dfc499492966c64dcf
   -- ARROW_GLOG_BUILD_VERSION: v0.5.0
   -- ARROW_GLOG_BUILD_SHA256_CHECKSUM: eede71f28371bf39aa69b45de23b329d37214016e2055269b3b5e7cfd40b59f5
   -- ARROW_GOOGLE_CLOUD_CPP_BUILD_VERSION: v2.12.0
   -- ARROW_GOOGLE_CLOUD_CPP_BUILD_SHA256_CHECKSUM: 8cda870803925c62de8716a765e03eb9d34249977e5cdb7d0d20367e997a55e2
   -- ARROW_GRPC_BUILD_VERSION: v1.46.3
   -- ARROW_GRPC_BUILD_SHA256_CHECKSUM: d6cbf22cb5007af71b61c6be316a79397469c58c82a942552a62e708bce60964
   -- ARROW_GTEST_BUILD_VERSION: 1.11.0
   -- ARROW_GTEST_BUILD_SHA256_CHECKSUM: b4870bf121ff7795ba20d20bcdd8627b8e088f2d1dab299a031c1034eddc93d5
   -- ARROW_JEMALLOC_BUILD_VERSION: 5.3.0
   -- ARROW_JEMALLOC_BUILD_SHA256_CHECKSUM: 2db82d1e7119df3e71b7640219b6dfe84789bc0537983c3b7ac4f7189aecfeaa
   -- ARROW_LZ4_BUILD_VERSION: v1.9.4
   -- ARROW_LZ4_BUILD_SHA256_CHECKSUM: 0b0e3aa07c8c063ddf40b082bdf7e37a1562bda40a0ff5272957f3e987e0e54b
   -- ARROW_MIMALLOC_BUILD_VERSION: v2.0.6
   -- ARROW_MIMALLOC_BUILD_SHA256_CHECKSUM: 9f05c94cc2b017ed13698834ac2a3567b6339a8bde27640df5a1581d49d05ce5
   -- ARROW_NLOHMANN_JSON_BUILD_VERSION: v3.10.5
   -- ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM: 5daca6ca216495edf89d167f808d1d03c4a4d929cef7da5e10f135ae1540c7e4
   -- ARROW_OPENTELEMETRY_BUILD_VERSION: v1.8.1
   -- ARROW_OPENTELEMETRY_BUILD_SHA256_CHECKSUM: 3d640201594b07f08dade9cd1017bd0b59674daca26223b560b9bb6bf56264c2
   -- ARROW_OPENTELEMETRY_PROTO_BUILD_VERSION: v0.17.0
   -- ARROW_OPENTELEMETRY_PROTO_BUILD_SHA256_CHECKSUM: f269fbcb30e17b03caa1decd231ce826e59d7651c0f71c3b28eb5140b4bb5412
   -- ARROW_ORC_BUILD_VERSION: 1.9.0
   -- ARROW_ORC_BUILD_SHA256_CHECKSUM: 0dca8bbccdb2ee87e59ba964933436beebd02ea78c4134424828a8127fbc4faa
   -- ARROW_PROTOBUF_BUILD_VERSION: v21.3
   -- ARROW_PROTOBUF_BUILD_SHA256_CHECKSUM: 2f723218f6cb709ae4cdc4fb5ed56a5951fc5d466f0128ce4c946b8c78c8c49f
   -- ARROW_RAPIDJSON_BUILD_VERSION: 232389d4f1012dddec4ef84861face2d2ba85709
   -- ARROW_RAPIDJSON_BUILD_SHA256_CHECKSUM: b9290a9a6d444c8e049bd589ab804e0ccf2b05dc5984a19ed5ae75d090064806
   -- ARROW_RE2_BUILD_VERSION: 2022-06-01
   -- ARROW_RE2_BUILD_SHA256_CHECKSUM: f89c61410a072e5cbcf8c27e3a778da7d6fd2f2b5b1445cd4f4508bee946ab0f
   -- ARROW_SNAPPY_BUILD_VERSION: 1.1.10
   -- ARROW_SNAPPY_BUILD_SHA256_CHECKSUM: 49d831bffcc5f3d01482340fe5af59852ca2fe76c3e05df0e67203ebbe0f1d90
   -- ARROW_SUBSTRAIT_BUILD_VERSION: v0.27.0
   -- ARROW_SUBSTRAIT_BUILD_SHA256_CHECKSUM: 4ed375f69d972a57fdc5ec406c17003a111831d8640d3f1733eccd4b3ff45628
   -- ARROW_S2N_TLS_BUILD_VERSION: v1.3.35
   -- ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM: 9d32b26e6bfcc058d98248bf8fc231537e347395dd89cf62bb432b55c5da990d
   -- ARROW_THRIFT_BUILD_VERSION: 0.16.0
   -- ARROW_THRIFT_BUILD_SHA256_CHECKSUM: f460b5c1ca30d8918ff95ea3eb6291b3951cf518553566088f3f2be8981f6209
   -- ARROW_UCX_BUILD_VERSION: 1.12.1
   -- ARROW_UCX_BUILD_SHA256_CHECKSUM: 9bef31aed0e28bf1973d28d74d9ac4f8926c43ca3b7010bd22a084e164e31b71
   -- ARROW_UTF8PROC_BUILD_VERSION: v2.7.0
   -- ARROW_UTF8PROC_BUILD_SHA256_CHECKSUM: 4bb121e297293c0fd55f08f83afab6d35d48f0af4ecc07523ad8ec99aa2b12a1
   -- ARROW_XSIMD_BUILD_VERSION: 9.0.1
   -- ARROW_XSIMD_BUILD_SHA256_CHECKSUM: b1bb5f92167fd3a4f25749db0be7e61ed37e0a5d943490f3accdcd2cd2918cc0
   -- ARROW_ZLIB_BUILD_VERSION: 1.2.13
   -- ARROW_ZLIB_BUILD_SHA256_CHECKSUM: b3a24de97a8fdbc835b9833169501030b8977031bcb54b3b3ac13740f846ab30
   -- ARROW_ZSTD_BUILD_VERSION: 1.5.5
   -- ARROW_ZSTD_BUILD_SHA256_CHECKSUM: 9c4396cc829cfae319a6e2615202e82aad41372073482fce286fac78646d3ee4
   -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
   -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
   -- Check if compiler accepts -pthread
   -- Check if compiler accepts -pthread - no
   -- Looking for pthread_create in pthreads
   -- Looking for pthread_create in pthreads - not found
   -- Looking for pthread_create in pthread
   -- Looking for pthread_create in pthread - not found
   CMake Error at /usr/local/Cellar/cmake/3.27.7/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
     Could NOT find Threads (missing: Threads_FOUND)
   Call Stack (most recent call first):
     /usr/local/Cellar/cmake/3.27.7/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
     /usr/local/Cellar/cmake/3.27.7/share/cmake/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
     cmake_modules/ThirdpartyToolchain.cmake:1020 (find_package)
     CMakeLists.txt:542 (include)
   
   
   -- Configuring incomplete, errors occurred!
   **** Error building Arrow C++. 
   PKG_CFLAGS=
   PKG_LIBS= 
   ** libs
   using C++ compiler: ‘g++ (GCC) 8.2.0’
   using C++17
   using SDK: ‘MacOSX13.3.sdk’
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c RTasks.cpp -o RTasks.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c altrep.cpp -o altrep.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c array.cpp -o array.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c array_to_vector.cpp -o array_to_vector.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c arraydata.cpp -o arraydata.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c arrowExports.cpp -o arrowExports.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c bridge.cpp -o bridge.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c buffer.cpp -o buffer.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c chunkedarray.cpp -o chunkedarray.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c compression.cpp -o compression.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c compute-exec.cpp -o compute-exec.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c compute.cpp -o compute.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c config.cpp -o config.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c csv.cpp -o csv.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c dataset.cpp -o dataset.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c datatype.cpp -o datatype.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c expression.cpp -o expression.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c extension-impl.cpp -o extension-impl.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c feather.cpp -o feather.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c field.cpp -o field.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c filesystem.cpp -o filesystem.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c io.cpp -o io.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c json.cpp -o json.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c memorypool.cpp -o memorypool.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c message.cpp -o message.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c parquet.cpp -o parquet.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c r_to_arrow.cpp -o r_to_arrow.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c recordbatch.cpp -o recordbatch.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c recordbatchreader.cpp -o recordbatchreader.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c recordbatchwriter.cpp -o recordbatchwriter.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c safe-call-into-r-impl.cpp -o safe-call-into-r-impl.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c scalar.cpp -o scalar.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c schema.cpp -o schema.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c symbols.cpp -o symbols.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c table.cpp -o table.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c threadpool.cpp -o threadpool.o
   clang++ -arch x86_64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG  -I'/Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/library/cpp11/include' -I/usr/local/gfortran/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include    -fPIC  -falign-functions=64 -Wall -g -O2  -UNDEBUG -Wall -pedantic -g -O0 -fdiagnostics-color=always -c type_infer.cpp -o type_infer.o
   clang++ -arch x86_64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/usr/local/gfortran/lib -Wl,-rpath,/usr/local/gfortran/lib -o arrow.so RTasks.o altrep.o array.o array_to_vector.o arraydata.o arrowExports.o bridge.o buffer.o chunkedarray.o compression.o compute-exec.o compute.o config.o csv.o dataset.o datatype.o expression.o extension-impl.o feather.o field.o filesystem.o io.o json.o memorypool.o message.o parquet.o r_to_arrow.o recordbatch.o recordbatchreader.o recordbatchwriter.o safe-call-into-r-impl.o scalar.o schema.o symbols.o table.o threadpool.o type_infer.o -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
   installing to /private/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T/RtmpoOY8O8/devtools_install_4611604d3163/00LOCK-r/00new/arrow/libs
   ** checking absolute paths in shared objects and dynamic libraries
─  DONE (arrow)
Error in dyn.load(dll_copy_file) : 
  unable to load shared object '/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//RtmpoOY8O8/pkgload461156aceb14/arrow.so':
  dlopen(/var/folders/gh/kkjkl7md3ml943xf33hqg6540000gp/T//RtmpoOY8O8/pkgload461156aceb14/arrow.so, 0x0006): symbol not found in flat namespace '__ZN5arrow12ArrayBuilder12AppendScalarERKNS_6ScalarEx'

@amoeba
Copy link
Member

amoeba commented Oct 12, 2023

Thanks @orgadish, I'm not totally sure what the issue is there but others may. As a way forward, could you try downloading a pre-compiled version of libarrow and trying to build the R package with that instead? Steps would be:

  • Download the latest zip from https://nightlies.apache.org/arrow/r/libarrow/bin/darwin-x86_64-openssl-3.0/
  • Create a folder in your Arrow source checkout at ./r/libarrow. Remove or empty the folder if it already exists.
  • Unzip the zip you downloaded into it. It should create a folder arrow-13.0.0.100000286 or similar
  • Rename the folder to arrow-13.0.0.9000
    • Your final structure should look like:
      ❯ tree -L 2 /path/to/arrow/clone/r/libarrow
      libarrow
      └── arrow-13.0.0.9000
          ├── include
          └── lib
      
  • Run devtools::load_all() again and let us know how that goes

@orgadish
Copy link
Contributor Author

Woohoo, looks like that worked! Note: I had to use pkgbuild::clean_dll() to force a recompile.

Thanks! I'll reach out if I need more help fixing the PR test failures.

@amoeba
Copy link
Member

amoeba commented Oct 12, 2023

Thanks for giving it a try and glad it worked.

thisisnic added a commit that referenced this issue Oct 19, 2023
### Rationale for this change
#38033 

### What changes are included in this PR?
- ~~Added `get_pkg_ns()` helper.~~
- ~~Added `call_name` private method to `DataType` class to store the string name used in the code call. Refactored `code()` public method to use `call_name`.~~
- Converted all `$code() call(...)` to `$code(namespace = FALSE) call2(..., .ns = if(namespace) "arrow")` in `DataType`, `Schema`, and `DictionaryType`.
- Added `code` to `Schema` docstring.
- Updated `expect_code_roundtrip` to test roundtrip with and without namespace, and check match/no match for `arrow::` depending on namespace argument.

### Are these changes tested?
* All tests pass, including lintr checks.

### Are there any user-facing changes?
Yes, user-facing changes, but no breaking changes to any public APIs.
* Closes: #38033

Lead-authored-by: orgadish <[email protected]>
Co-authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
@thisisnic thisisnic added this to the 15.0.0 milestone Oct 19, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
…ache#38144)

### Rationale for this change
apache#38033 

### What changes are included in this PR?
- ~~Added `get_pkg_ns()` helper.~~
- ~~Added `call_name` private method to `DataType` class to store the string name used in the code call. Refactored `code()` public method to use `call_name`.~~
- Converted all `$code() call(...)` to `$code(namespace = FALSE) call2(..., .ns = if(namespace) "arrow")` in `DataType`, `Schema`, and `DictionaryType`.
- Added `code` to `Schema` docstring.
- Updated `expect_code_roundtrip` to test roundtrip with and without namespace, and check match/no match for `arrow::` depending on namespace argument.

### Are these changes tested?
* All tests pass, including lintr checks.

### Are there any user-facing changes?
Yes, user-facing changes, but no breaking changes to any public APIs.
* Closes: apache#38033

Lead-authored-by: orgadish <[email protected]>
Co-authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
…ache#38144)

### Rationale for this change
apache#38033 

### What changes are included in this PR?
- ~~Added `get_pkg_ns()` helper.~~
- ~~Added `call_name` private method to `DataType` class to store the string name used in the code call. Refactored `code()` public method to use `call_name`.~~
- Converted all `$code() call(...)` to `$code(namespace = FALSE) call2(..., .ns = if(namespace) "arrow")` in `DataType`, `Schema`, and `DictionaryType`.
- Added `code` to `Schema` docstring.
- Updated `expect_code_roundtrip` to test roundtrip with and without namespace, and check match/no match for `arrow::` depending on namespace argument.

### Are these changes tested?
* All tests pass, including lintr checks.

### Are there any user-facing changes?
Yes, user-facing changes, but no breaking changes to any public APIs.
* Closes: apache#38033

Lead-authored-by: orgadish <[email protected]>
Co-authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…ache#38144)

### Rationale for this change
apache#38033 

### What changes are included in this PR?
- ~~Added `get_pkg_ns()` helper.~~
- ~~Added `call_name` private method to `DataType` class to store the string name used in the code call. Refactored `code()` public method to use `call_name`.~~
- Converted all `$code() call(...)` to `$code(namespace = FALSE) call2(..., .ns = if(namespace) "arrow")` in `DataType`, `Schema`, and `DictionaryType`.
- Added `code` to `Schema` docstring.
- Updated `expect_code_roundtrip` to test roundtrip with and without namespace, and check match/no match for `arrow::` depending on namespace argument.

### Are these changes tested?
* All tests pass, including lintr checks.

### Are there any user-facing changes?
Yes, user-facing changes, but no breaking changes to any public APIs.
* Closes: apache#38033

Lead-authored-by: orgadish <[email protected]>
Co-authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…ache#38144)

### Rationale for this change
apache#38033 

### What changes are included in this PR?
- ~~Added `get_pkg_ns()` helper.~~
- ~~Added `call_name` private method to `DataType` class to store the string name used in the code call. Refactored `code()` public method to use `call_name`.~~
- Converted all `$code() call(...)` to `$code(namespace = FALSE) call2(..., .ns = if(namespace) "arrow")` in `DataType`, `Schema`, and `DictionaryType`.
- Added `code` to `Schema` docstring.
- Updated `expect_code_roundtrip` to test roundtrip with and without namespace, and check match/no match for `arrow::` depending on namespace argument.

### Are these changes tested?
* All tests pass, including lintr checks.

### Are there any user-facing changes?
Yes, user-facing changes, but no breaking changes to any public APIs.
* Closes: apache#38033

Lead-authored-by: orgadish <[email protected]>
Co-authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants