[R] Setting rosetta variable is missing #37907
Assignees
Labels
Milestone
Comments
thisisnic
changed the title
|
Thanks for reporting this @pascalgulikers , I'll have a PR up shortly to fix this! |
This was referenced Oct 2, 2023
paleolimbot
added
Priority: Blocker
thisisnic
pushed a commit
that referenced
this issue
Oct 12, 2023
### Rationale for this change
The latest version of `r/R/install-arrow.R` was not working properly, since it was relying on the `on_rosetta()` function, which is not defined elsewhere. I just fixed the identification of rosetta in the script.
With the current code, the following gives an error
````r
> source("https://raw.githubusercontent.com/apache/arrow/master/r/R/install-arrow.R")
> install_arrow()
Error in on_rosetta() : could not find function "on_rosetta"
````
### What changes are included in this PR?
It only removed the `on_rosetta()` function, which was not defined elsewhere, and reverted back to the `rosetta` object to identify if rosetta is present or not on a user's system.
### Are these changes tested?
Yes. It was tested with the current code and the proposed PR. The proposed PR works as expected.
### Are there any user-facing changes?
No.
* Closes: #37907
Lead-authored-by: Fernando Mayer <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
raulcd
pushed a commit
that referenced
this issue
Oct 13, 2023
### Rationale for this change
The latest version of `r/R/install-arrow.R` was not working properly, since it was relying on the `on_rosetta()` function, which is not defined elsewhere. I just fixed the identification of rosetta in the script.
With the current code, the following gives an error
````r
> source("https://raw.githubusercontent.com/apache/arrow/master/r/R/install-arrow.R")
> install_arrow()
Error in on_rosetta() : could not find function "on_rosetta"
````
### What changes are included in this PR?
It only removed the `on_rosetta()` function, which was not defined elsewhere, and reverted back to the `rosetta` object to identify if rosetta is present or not on a user's system.
### Are these changes tested?
Yes. It was tested with the current code and the proposed PR. The proposed PR works as expected.
### Are there any user-facing changes?
No.
* Closes: #37907
Lead-authored-by: Fernando Mayer <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
### Rationale for this change
The latest version of `r/R/install-arrow.R` was not working properly, since it was relying on the `on_rosetta()` function, which is not defined elsewhere. I just fixed the identification of rosetta in the script.
With the current code, the following gives an error
````r
> source("https://raw.githubusercontent.com/apache/arrow/master/r/R/install-arrow.R")
> install_arrow()
Error in on_rosetta() : could not find function "on_rosetta"
````
### What changes are included in this PR?
It only removed the `on_rosetta()` function, which was not defined elsewhere, and reverted back to the `rosetta` object to identify if rosetta is present or not on a user's system.
### Are these changes tested?
Yes. It was tested with the current code and the proposed PR. The proposed PR works as expected.
### Are there any user-facing changes?
No.
* Closes: apache#37907
Lead-authored-by: Fernando Mayer <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
### Rationale for this change
The latest version of `r/R/install-arrow.R` was not working properly, since it was relying on the `on_rosetta()` function, which is not defined elsewhere. I just fixed the identification of rosetta in the script.
With the current code, the following gives an error
````r
> source("https://raw.githubusercontent.com/apache/arrow/master/r/R/install-arrow.R")
> install_arrow()
Error in on_rosetta() : could not find function "on_rosetta"
````
### What changes are included in this PR?
It only removed the `on_rosetta()` function, which was not defined elsewhere, and reverted back to the `rosetta` object to identify if rosetta is present or not on a user's system.
### Are these changes tested?
Yes. It was tested with the current code and the proposed PR. The proposed PR works as expected.
### Are there any user-facing changes?
No.
* Closes: apache#37907
Lead-authored-by: Fernando Mayer <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
### Rationale for this change
The latest version of `r/R/install-arrow.R` was not working properly, since it was relying on the `on_rosetta()` function, which is not defined elsewhere. I just fixed the identification of rosetta in the script.
With the current code, the following gives an error
````r
> source("https://raw.githubusercontent.com/apache/arrow/master/r/R/install-arrow.R")
> install_arrow()
Error in on_rosetta() : could not find function "on_rosetta"
````
### What changes are included in this PR?
It only removed the `on_rosetta()` function, which was not defined elsewhere, and reverted back to the `rosetta` object to identify if rosetta is present or not on a user's system.
### Are these changes tested?
Yes. It was tested with the current code and the proposed PR. The proposed PR works as expected.
### Are there any user-facing changes?
No.
* Closes: apache#37907
Lead-authored-by: Fernando Mayer <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Since the last release, this line is missing in /r/R/install_arrow.R. This causes the R script to fail execution
https://github.com/apache/arrow/blame/b7d2f7ffca66c868bd2fce5b3749c6caa002a7f0/r/R/install-arrow.R#L83
Proposed solution: put back this line:
rosetta <- identical(sysname, "darwin") && identical(system("sysctl -n sysctl.proc_translated", intern = TRUE), "1")Component(s)
R
The text was updated successfully, but these errors were encountered: