-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] cpp/src/**/*.cmake aren't cmake-format targets #37849
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Sep 25, 2023
kou
added a commit
that referenced
this issue
Sep 25, 2023
### Rationale for this change In general, all our `.cmake` files should be `cmake-format` targets. ### What changes are included in this PR? Add missing patterns for `cpp/src/**/*.cmake`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #37849 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
etseidl
pushed a commit
to etseidl/arrow
that referenced
this issue
Sep 28, 2023
…pache#37850) ### Rationale for this change In general, all our `.cmake` files should be `cmake-format` targets. ### What changes are included in this PR? Add missing patterns for `cpp/src/**/*.cmake`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37849 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…pache#37850) ### Rationale for this change In general, all our `.cmake` files should be `cmake-format` targets. ### What changes are included in this PR? Add missing patterns for `cpp/src/**/*.cmake`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37849 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…pache#37850) ### Rationale for this change In general, all our `.cmake` files should be `cmake-format` targets. ### What changes are included in this PR? Add missing patterns for `cpp/src/**/*.cmake`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37849 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…pache#37850) ### Rationale for this change In general, all our `.cmake` files should be `cmake-format` targets. ### What changes are included in this PR? Add missing patterns for `cpp/src/**/*.cmake`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37849 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Our configuration misses them:
arrow/dev/archery/archery/utils/lint.py
Lines 149 to 166 in 772a01c
Component(s)
C++
The text was updated successfully, but these errors were encountered: