Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][MATLAB] Hard-code release to R2023a for matlab-actions/setup-matlab action in MATLAB CI workflows #37805

Closed
kevingurney opened this issue Sep 20, 2023 · 3 comments · Fixed by #37808
Closed

[CI][MATLAB] Hard-code release to R2023a for matlab-actions/setup-matlab action in MATLAB CI workflows #37805

kevingurney opened this issue Sep 20, 2023 · 3 comments · Fixed by #37808
Assignees
@kevingurney
Labels
Component: Continuous Integration Component: MATLAB Type: bug
Milestone
14.0.0

Comments

@kevingurney
Copy link
Member

kevingurney commented Sep 20, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Due to a recent change to default to R2023b by default for the [matlab-actions/setup-matlab](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.

Example failure logs:

https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70

Our preferred solution to address this in the short term is to explicitly specify the release parameter to the setup-matlab action to be R2023a.

In the long term, we can work on figuring out why the build is failing on Windows with R2023b.

For reference - it appears that the FindMatlab CMake module only recently added R2023b to its list of recognized versions:

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804

Component(s)

Continuous Integration, MATLAB
@github-project-automation github-project-automation bot moved this to Backlog in Arrow MATLAB Sep 20, 2023
@kevingurney kevingurney changed the title [CI][MATLAB] MATLAB CI workflows failing due to move to R2023b by default in matlab-actions/setup-matlab [CI][MATLAB] MATLAB CI workflows failing on Windows due to move to R2023b by default in matlab-actions/setup-matlab Sep 20, 2023
@kevingurney kevingurney mentioned this issue Sep 20, 2023
Merged
@kevingurney kevingurney self-assigned this Sep 20, 2023
@kevingurney
Copy link
Member Author

kevingurney commented Sep 20, 2023 •
edited
Loading

I'm actively investigating these failures now on https://github.com/mathworks/arrow/tree/GH-37805.

Most likely, I will just hard-code the release to R2023a for the time being.

@kevingurney kevingurney changed the title [CI][MATLAB] MATLAB CI workflows failing on Windows due to move to R2023b by default in matlab-actions/setup-matlab [CI][MATLAB] Hard-code release to R2023a for matlab-actions/setup-matlab action in MATLAB CI workflows Sep 20, 2023
@kevingurney
Copy link
Member Author

Hard-coding the release to R2023a appears to resolve this issue:

https://github.com/mathworks/arrow/actions/runs/6251345588.

I'll create a PR for this.

@github-actions github-actions bot mentioned this issue Sep 20, 2023
Merged
@kevingurney
Copy link
Member Author

I've opened PR #37808 to address this issue.

I've also created #37809 as a follow up to determine why the MATLAB workflows are failing on Windows when using MATLAB R2023b.

@kevingurney kevingurney moved this from Backlog to Todo in Arrow MATLAB Sep 20, 2023
@kevingurney kevingurney moved this from Todo to In Progress in Arrow MATLAB Sep 20, 2023
kevingurney added a commit that referenced this issue Sep 20, 2023
@kevingurney
GH-37805: [CI][MATLAB] Hard-code release to R2023a for `matlab-ac…
e068b7f 
…tions/setup-matlab` action in MATLAB CI workflows (#37808)

### Rationale for this change

Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.

Example failure logs:

https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70

Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`.

In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`.

For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions:

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804

### What changes are included in this PR?

1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows.

### Are these changes tested?

Yes.

1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588).

### Are there any user-facing changes?

No.

This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past.

### Future Directions

1. #37809
* Closes: #37805

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arrow MATLAB Sep 20, 2023
@kevingurney kevingurney added this to the 14.0.0 milestone Sep 20, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@kevingurney
apacheGH-37805: [CI][MATLAB] Hard-code release to R2023a for `mat…
8d07717 
…lab-actions/setup-matlab` action in MATLAB CI workflows (apache#37808)

### Rationale for this change

Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.

Example failure logs:

https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70

Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`.

In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`.

For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions:

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804

### What changes are included in this PR?

1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows.

### Are these changes tested?

Yes.

1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588).

### Are there any user-facing changes?

No.

This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past.

### Future Directions

1. apache#37809
* Closes: apache#37805

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kevingurney @loicalleyne
apacheGH-37805: [CI][MATLAB] Hard-code release to R2023a for `mat…
1c04196 
…lab-actions/setup-matlab` action in MATLAB CI workflows (apache#37808)

### Rationale for this change

Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.

Example failure logs:

https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70

Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`.

In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`.

For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions:

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804

### What changes are included in this PR?

1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows.

### Are these changes tested?

Yes.

1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588).

### Are there any user-facing changes?

No.

This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past.

### Future Directions

1. apache#37809
* Closes: apache#37805

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kevingurney @dgreiss
apacheGH-37805: [CI][MATLAB] Hard-code release to R2023a for `mat…
8f8260c 
…lab-actions/setup-matlab` action in MATLAB CI workflows (apache#37808)

### Rationale for this change

Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.

Example failure logs:

https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70

Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`.

In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`.

For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions:

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804

### What changes are included in this PR?

1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows.

### Are these changes tested?

Yes.

1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588).

### Are there any user-facing changes?

No.

This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past.

### Future Directions

1. apache#37809
* Closes: apache#37805

Authored-by: Kevin Gurney <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevingurney kevingurney

Labels
Component: Continuous Integration Component: MATLAB Type: bug
Projects
Arrow MATLAB
Archived in project
Milestone
14.0.0
1 participant
@kevingurney