[C++][Gandiva] Exported functions are registered multiple times in gandiva #37751
Comments
pitrou
pushed a commit
that referenced
this issue
Oct 16, 2023
…e times in gandiva (#37752) ### Rationale for this change Try to fix #37751 ### What changes are included in this PR? The exported functions defined in gandiva are registered multiple times unnecessarily. This PR tries to address this issue. ### Are these changes tested? Yes. ### Are there any user-facing changes? No Authored-by: Yue Ni <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
Issue resolved by pull request 37752 |
kou
changed the title
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…ultiple times in gandiva (apache#37752) ### Rationale for this change Try to fix apache#37751 ### What changes are included in this PR? The exported functions defined in gandiva are registered multiple times unnecessarily. This PR tries to address this issue. ### Are these changes tested? Yes. ### Are there any user-facing changes? No Authored-by: Yue Ni <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…ultiple times in gandiva (apache#37752) ### Rationale for this change Try to fix apache#37751 ### What changes are included in this PR? The exported functions defined in gandiva are registered multiple times unnecessarily. This PR tries to address this issue. ### Are these changes tested? Yes. ### Are there any user-facing changes? No Authored-by: Yue Ni <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…ultiple times in gandiva (apache#37752) ### Rationale for this change Try to fix apache#37751 ### What changes are included in this PR? The exported functions defined in gandiva are registered multiple times unnecessarily. This PR tries to address this issue. ### Are these changes tested? Yes. ### Are there any user-facing changes? No Authored-by: Yue Ni <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
The exported functions defined in gandiva are registered multiple times unnecessarily.
Currently, in gandiva, exported functions are registered to the function registry in
exported_funcs.hby using a macroREGISTER_EXPORTED_FUNCS, which internally defines a static variable to call the registration. Since this header file (exported_funcs.h) is included in multiple times in different files (7 different files more specifically), this makes the registration happens 7 times for the same set of functions, which is not necessary. It makes the initialization slower, additionally, it makes the registration to contain duplicated functions (although it still works so far).Component(s)
C++ - Gandiva
The text was updated successfully, but these errors were encountered: