Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Integration] Add C++ implementation of Utf8View #37710

Closed
bkietz opened this issue Sep 13, 2023 · 0 comments · Fixed by #37792
Closed

[C++][Integration] Add C++ implementation of Utf8View #37710

bkietz opened this issue Sep 13, 2023 · 0 comments · Fixed by #37792
Assignees
@bkietz
Labels
Component: C++ Component: Integration Type: enhancement
Milestone
15.0.0

Comments

@bkietz
Copy link
Member

bkietz commented Sep 13, 2023

Describe the enhancement requested

The original PR #35628 is huge and difficult to review. A separate PR #37526 has been extracted to make the minimal changes to the spec and schemas to enable other implementations to proceed without waiting for C++ to merge.

Component(s)

C++, Integration
@bkietz bkietz self-assigned this Sep 13, 2023
bkietz added a commit to bkietz/arrow that referenced this issue Sep 19, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
612f371
@github-actions github-actions bot mentioned this issue Sep 19, 2023
Merged
bkietz added a commit to bkietz/arrow that referenced this issue Sep 19, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
03b3335
bkietz added a commit to bkietz/arrow that referenced this issue Sep 19, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
004a844
bkietz added a commit to bkietz/arrow that referenced this issue Sep 20, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
9b867e3
bkietz added a commit to bkietz/arrow that referenced this issue Sep 20, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
d468860
bkietz added a commit to bkietz/arrow that referenced this issue Sep 20, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
660008f
bkietz added a commit to bkietz/arrow that referenced this issue Sep 20, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
614a411
bkietz added a commit to bkietz/arrow that referenced this issue Sep 21, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
b62d539
bkietz added a commit to bkietz/arrow that referenced this issue Oct 10, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
7416749
bkietz added a commit to bkietz/arrow that referenced this issue Oct 26, 2023
@bkietz
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation
2e8f25d
bkietz added a commit that referenced this issue Oct 26, 2023
@bkietz
GH-37710: [C++][Integration] Add C++ Utf8View implementation (#37792)
f622139 
### Rationale for this change

After the PR changing the spec and schema ( #37526 ) is accepted, this PR will be undrafted. It adds the minimal addition of a C++ implementation and was extracted from the original C++ Utf8View pr ( #35628 ) for ease of review.

### What changes are included in this PR?

- The new types are available with new subclasses of DataType, Array, ArrayBuilder, ...
- The values of string view arrays can be visited as `std::string_view` as with StringArray
- String view arrays can be round tripped through IPC and integration JSON

* Closes: #37710

Relevant mailing list discussions: 
* https://lists.apache.org/thread/l8t1vj5x1wdf75mdw3wfjvnxrfy5xomy
* https://lists.apache.org/thread/3qhkomvvc69v3gkotbwldyko7yk9cs9k

Authored-by: Benjamin Kietzman <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
@bkietz bkietz added this to the 15.0.0 milestone Oct 26, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@bkietz @loicalleyne
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation (a…
0ccedb5 
…pache#37792)

### Rationale for this change

After the PR changing the spec and schema ( apache#37526 ) is accepted, this PR will be undrafted. It adds the minimal addition of a C++ implementation and was extracted from the original C++ Utf8View pr ( apache#35628 ) for ease of review.

### What changes are included in this PR?

- The new types are available with new subclasses of DataType, Array, ArrayBuilder, ...
- The values of string view arrays can be visited as `std::string_view` as with StringArray
- String view arrays can be round tripped through IPC and integration JSON

* Closes: apache#37710

Relevant mailing list discussions: 
* https://lists.apache.org/thread/l8t1vj5x1wdf75mdw3wfjvnxrfy5xomy
* https://lists.apache.org/thread/3qhkomvvc69v3gkotbwldyko7yk9cs9k

Authored-by: Benjamin Kietzman <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@bkietz @dgreiss
apacheGH-37710: [C++][Integration] Add C++ Utf8View implementation (a…
444e9a4 
…pache#37792)

### Rationale for this change

After the PR changing the spec and schema ( apache#37526 ) is accepted, this PR will be undrafted. It adds the minimal addition of a C++ implementation and was extracted from the original C++ Utf8View pr ( apache#35628 ) for ease of review.

### What changes are included in this PR?

- The new types are available with new subclasses of DataType, Array, ArrayBuilder, ...
- The values of string view arrays can be visited as `std::string_view` as with StringArray
- String view arrays can be round tripped through IPC and integration JSON

* Closes: apache#37710

Relevant mailing list discussions: 
* https://lists.apache.org/thread/l8t1vj5x1wdf75mdw3wfjvnxrfy5xomy
* https://lists.apache.org/thread/3qhkomvvc69v3gkotbwldyko7yk9cs9k

Authored-by: Benjamin Kietzman <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkietz bkietz

Labels
Component: C++ Component: Integration Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-37710: [C++][Integration] Add C++ Utf8View implementation bkietz/arrow
1 participant
@bkietz