-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packaging][RPM] *.rpm have too much dependencies #36832
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Jul 24, 2023
raulcd
pushed a commit
that referenced
this issue
Jul 25, 2023
### Rationale for this change `arrowXX-libs` doesn't use `gflags` but it depends on `gflags`. ### What changes are included in this PR? Remove needless explicit `Requires`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #36832 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
raulcd
pushed a commit
that referenced
this issue
Jul 25, 2023
### Rationale for this change `arrowXX-libs` doesn't use `gflags` but it depends on `gflags`. ### What changes are included in this PR? Remove needless explicit `Requires`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #36832 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
### Rationale for this change `arrowXX-libs` doesn't use `gflags` but it depends on `gflags`. ### What changes are included in this PR? Remove needless explicit `Requires`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36832 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
### Rationale for this change `arrowXX-libs` doesn't use `gflags` but it depends on `gflags`. ### What changes are included in this PR? Remove needless explicit `Requires`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36832 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
rpmbuild
generates dependency information based of linked shared libraries automatically.For example,
arrow12-libs
has the following dependency information:If we have
libzstd.so.1()(64bit)
in it, we don't need to addRequires: libzstd
to ourarrow.spec
explicitly.But we need
Requires: lz4-libs >= 1.8.0
even when we haveliblz4.so.1()(64bit)
because lz4 version information doesn't exist inliblz4.so.1()(64bit)
. (If LZ4 usesliblz4.so.2
for LZ4 1.8.0 or later, we don't needRequires: lz4-libs >= 1.8.0
.)The Zstandard dependency is harmless. It's just duplicated. But the gflags dependency is needless because
arrow12-libs
doesn't use it.Component(s)
Packaging
The text was updated successfully, but these errors were encountered: