[C++] CI failures on Windows & Substrait (appears to be abseil linking issues)

[westonpace]

Describe the bug, including details regarding any error messages, version, and platform.

I've seen this CI failure pop up recently on two unrelated PRs.

Example:

https://github.com/apache/arrow/actions/runs/5509303570/jobs/10041817398?pr=35440

 FAILED: release/libarrow_substrait.dll release/libarrow_substrait.dll.a 
cmd.exe /C "cd . && D:\a\_temp\msys64\mingw32\bin\c++.exe -Wno-noexcept-type -Wno-self-move  -fdiagnostics-color=always  -Wa,-mbig-obj -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -Wdate-time -fno-semantic-interposition -mxsave -msse4.2  -O3 -DNDEBUG -O2 -ftree-vectorize  -Wl,--version-script=D:/a/arrow/arrow/cpp/src/arrow/symbols.map -shared -o release\libarrow_substrait.dll -Wl,--out-implib,release\libarrow_substrait.dll.a -Wl,--major-image-version,1300,--minor-image-version,0 @CMakeFiles\arrow_substrait_shared.rsp  && cd ."
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: src/arrow/engine/CMakeFiles/arrow_substrait_shared.dir/substrait/serde.cc.obj:serde.cc:(.text+0xf30): undefined reference to `absl::lts_20230125::operator<<(std::ostream&, absl::lts_20230125::Status const&)'
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: src/arrow/engine/CMakeFiles/arrow_substrait_shared.dir/substrait/serde.cc.obj:serde.cc:(.text+0x101c): undefined reference to `absl::lts_20230125::Status::UnrefNonInlined(unsigned int)'
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: src/arrow/engine/CMakeFiles/arrow_substrait_shared.dir/substrait/serde.cc.obj:serde.cc:(.text+0x141d): undefined reference to `absl::lts_20230125::operator<<(std::ostream&, absl::lts_20230125::Status const&)'
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: src/arrow/engine/CMakeFiles/arrow_substrait_shared.dir/substrait/serde.cc.obj:serde.cc:(.text+0x14f1): undefined reference to `absl::lts_20230125::Status::UnrefNonInlined(unsigned int)'
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: src/arrow/engine/CMakeFiles/arrow_substrait_shared.dir/substrait/serde.cc.obj:serde.cc:(.text$_ZN4absl12lts_202301256StatusD1Ev[__ZN4absl12lts_202301256StatusD1Ev]+0x17): undefined reference to `absl::lts_20230125::Status::UnrefNonInlined(unsigned int)'
D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/13.1.0/../../../../i686-w64-mingw32/bin/ld.exe: release/libsubstrait.a(algebra.pb.cc.obj):algebra.pb.cc:(.text$_ZN6google8protobuf13RepeatedFieldIiE14GrowNoAnnotateEii[__ZN6google8protobuf13RepeatedFieldIiE14GrowNoAnnotateEii]+0x8d): undefined reference to `__emutls_v._ZN6google8protobuf8internal15ThreadSafeArena13thread_cache_E'

It's very consistent. I am going to start investigating but wanted to create an issue in case someone was already looking into it.

Component(s)

C++

[westonpace]

From what I can tell so far is that the mingw builds are installing a system-wide grpc, protobuf, and abseil. So, IIUC, those should all be compatible and nothing should be getting bundled?

[westonpace]

Ok. I have confirmed locally that I get these exact errors when I try the versions of protobuf and abseil that pacman is installing:

libprotobuf               4.23.1               hd1fb520_0    conda-forge
libabseil                 20230125.3      cxx17_h59595ed_0    conda-forge

...which is unfortunate. Investigating further.

[westonpace]

#35987 is probably related. It seems we want a newer version of protobuf.

[westonpace]

@kou there is no protobuf 4.23.3 in mingw yet. Should we create an issue/PR at https://github.com/msys2/MINGW-packages ? I don't work with mingw much so I don't know the best approach.

[kou]

Thanks for investing this!
I'll open a pull request to fix this.

[raulcd]

@pitrou @kou should this be added to 13.0.0, I would think so.

[raulcd]

I've decided to add it.