Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Enable clang-format in the matlab/ subfolder. #35941

Closed
sgilmore10 opened this issue Jun 6, 2023 · 1 comment
Closed

[MATLAB] Enable clang-format in the matlab/ subfolder. #35941

sgilmore10 opened this issue Jun 6, 2023 · 1 comment
Assignees
@kou
Labels
Component: MATLAB Type: enhancement
Milestone
16.0.0

Comments

@sgilmore10
Copy link
Member

sgilmore10 commented Jun 6, 2023 •
edited by kevingurney
Loading

Describe the enhancement requested

Currently, there is no specific format that is enforced for the C++ code in the MATLAB interface. This makes it easy to make accidental formatting mistakes and leads to inconsistent code formatting (e.g. #38189 (comment)).

We should use clang-format on the source files in the matlab/ subfolder.

Component(s)

MATLAB
@sgilmore10 sgilmore10 mentioned this issue Jun 6, 2023
Merged
@kevingurney kevingurney mentioned this issue Oct 11, 2023
Closed
@kou kou mentioned this issue Mar 16, 2024
Open
kou added a commit to kou/arrow that referenced this issue Mar 16, 2024
@kou
apacheGH-35941: [Dev][MATLAB] Add clang-format configuration to pre-c…
b408674 
…ommit
@github-actions github-actions bot mentioned this issue Mar 16, 2024
Merged
kevingurney pushed a commit that referenced this issue Mar 19, 2024
@kou
GH-35941: [Dev][MATLAB] Add clang-format configuration to pre-commit (#…
8ec32aa 
…40588)

### Rationale for this change

If we use formatter, we don't need to check style manually.

### What changes are included in this PR?

* Add clang-format configuration to pre-commit
* This uses the same style as C++/Python/R uses

We can format by `pre-commit run -a`.
 
### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #35941

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Kevin Gurney <[email protected]>
@kevingurney
Copy link
Member

Issue resolved by pull request 40588
#40588

@kevingurney kevingurney added this to the 16.0.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
3 participants
@kou @kevingurney @sgilmore10