-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MATLAB] Add arrow.array.Float32Array
MATLAB Class
#35492
Comments
take |
sgilmore10
changed the title
Add
[MATLAB] Add May 8, 2023
arrow.array.Float32Array
MATLAB Classarrow.array.Float32Array
MATLAB Class
kou
added a commit
that referenced
this issue
May 15, 2023
### Rationale for this change Continuing to build the MATLAB interface to Arrow for numeric types. We're trying to keep the scope of these pull requests small to make them easier to review. ### What changes are included in this PR? 1. Added `arrow.array.Float32Array` MATLAB class 2. Added new test class `tFloat32Array.m` ### Are these changes tested? 1. Yes, added a new test class called `tFloat32Array.m`. 2. Qualified locally on macOS. ### Are there any user-facing changes? Yes, users can now create a array of float32 values. ### Future Directions 1. Continue building out support for numeric arrays. 2. Add shared validation functions. 3. Make a shared test class for Numeric Arrays. * Closes: #35492 Lead-authored-by: Sarah Gilmore <[email protected]> Co-authored-by: sgilmore10 <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Kevin Gurney <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…pache#35495) ### Rationale for this change Continuing to build the MATLAB interface to Arrow for numeric types. We're trying to keep the scope of these pull requests small to make them easier to review. ### What changes are included in this PR? 1. Added `arrow.array.Float32Array` MATLAB class 2. Added new test class `tFloat32Array.m` ### Are these changes tested? 1. Yes, added a new test class called `tFloat32Array.m`. 2. Qualified locally on macOS. ### Are there any user-facing changes? Yes, users can now create a array of float32 values. ### Future Directions 1. Continue building out support for numeric arrays. 2. Add shared validation functions. 3. Make a shared test class for Numeric Arrays. * Closes: apache#35492 Lead-authored-by: Sarah Gilmore <[email protected]> Co-authored-by: sgilmore10 <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Kevin Gurney <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…pache#35495) ### Rationale for this change Continuing to build the MATLAB interface to Arrow for numeric types. We're trying to keep the scope of these pull requests small to make them easier to review. ### What changes are included in this PR? 1. Added `arrow.array.Float32Array` MATLAB class 2. Added new test class `tFloat32Array.m` ### Are these changes tested? 1. Yes, added a new test class called `tFloat32Array.m`. 2. Qualified locally on macOS. ### Are there any user-facing changes? Yes, users can now create a array of float32 values. ### Future Directions 1. Continue building out support for numeric arrays. 2. Add shared validation functions. 3. Make a shared test class for Numeric Arrays. * Closes: apache#35492 Lead-authored-by: Sarah Gilmore <[email protected]> Co-authored-by: sgilmore10 <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Kevin Gurney <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Followup to #35480. Now that there is a common base class (
arrow.array.Array
) all MATLAB subclasses can inherit from, we can add basic support for more array types. Use this issue for float32 array support.Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: