Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] Add decimal support for arithmetic compute functions #28831

Closed
asfimport opened this issue Jun 21, 2021 · 4 comments
Closed

[C++][Compute] Add decimal support for arithmetic compute functions #28831

asfimport opened this issue Jun 21, 2021 · 4 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Jun 21, 2021

The following arithmetic functions do not support decimal:

  • abs

  • abs_checked

  • acos

  • acos_checked

  • asin

  • asin_checked

  • atan

  • ceil

  • cos

  • cos_checked

  • floor

  • is_finite (?)

  • is_inf (?)

  • is_nan (?)

  • ln

  • ln_checked

  • log1p

  • log1p_checked

  • log2

  • log2_checked

  • logb (float/decimal works int/decimal does not)

  • logb_checked (float/decimal works int/decimal does not)

  • mode

  • negate

  • negate_checked

  • power (float/decimal works int/decimal does not)

  • power_checked (float/decimal works int/decimal does not)

  • quantile

  • round (ARROW-13975)

  • round_to_multiple (ARROW-13975)

  • sign

  • sin

  • sin_checked

  • stddev

  • tan

  • tan_checked

  • tdigest

  • trunc

  • variance

    ? - May not be applicable

    The following kernels arithmetic functions do support decimal inputs

  • add

  • add_checked

  • atan2

  • divide

  • divide_checked

  • equal (ARROW-13966)

  • greater (ARROW-13966)

  • greater_equal (ARROW-13966)

  • less (ARROW-13966)

  • less_equal (ARROW-13966)

  • mean

  • min_max

  • multiply

  • multiply_checked

  • product

  • subtract

  • subtract_checked

  • sum

  • unique

Assignee: David Li / @lidavidm

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-13130. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
[~yibocai#1] I extended your existing abs/negate JIRA and added info about more kernels. If you want to keep the old description let me know and I can create a new JIRA.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
I think we can handle most of these by casting to float64 first (if we want, we could avoid the cast and do the conversion inline instead). abs, round (and ceil, floor, etc), mode, negate, quantile, and sign should be handled directly.

@asfimport
Copy link
Collaborator Author

Yibo Cai / @cyb70289:
@westonpace, no problem.
Just noticed this jira message. I don't know why the reporter of my old jira cards becomes this strange yibocai#1, which doesn't even exists.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11313
#11313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants