Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] Add remainder and quotient compute::Function #27909

Open
asfimport opened this issue Mar 25, 2021 · 3 comments
Open

[C++][Compute] Add remainder and quotient compute::Function #27909

asfimport opened this issue Mar 25, 2021 · 3 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Mar 25, 2021

In addition to divide which returns only the quotient, it'd be useful to have a function which returns both quotient and remainder (these are efficient to compute simultaneously), probably as a struct<quotient: T, remainder: T>.

Reporter: Ben Kietzman / @bkietz

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-12084. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
We have a bit of hackery in R to effect these with the existing compute kernel: https://github.com/apache/arrow/blob/master/r/R/expression.R#L71-L90

Would be great to delete that.

@asfimport
Copy link
Collaborator Author

Ian Cook / @ianmcook:
We should also expose quotient and modulo compute functions that would presumably use the same code as this but would return only the quotient or only the remainder (ARROW-12755)

@asfimport
Copy link
Collaborator Author

Apache Arrow JIRA Bot:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant