Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Compute] Add residual predicate support to new (Swiss) hash join #20339

Closed
asfimport opened this issue Jul 26, 2022 · 1 comment · Fixed by #39487
Closed

[C++][Compute] Add residual predicate support to new (Swiss) hash join #20339

asfimport opened this issue Jul 26, 2022 · 1 comment · Fixed by #39487
Assignees
@zanmato1984
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@asfimport
Copy link
Collaborator

asfimport commented Jul 26, 2022 •
edited
Loading

Only HashJoinBasicImpl supports residual predicates (non-equality joins). This functionality needs to be ported to SwissJoin as well.

Reporter: Michal Nowakiewicz / @michalursa

Related issues:

Note: This issue was originally created as ARROW-17202. Please see the migration documentation for further details.
@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@asfimport asfimport mentioned this issue Jan 11, 2023
Open
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
@github-actions github-actions bot mentioned this issue Jan 6, 2024
Merged
@zanmato1984
Copy link
Contributor

take

westonpace pushed a commit that referenced this issue Mar 12, 2024
@zanmato1984
GH-20339: [C++] Add residual filter support to swiss join (#39487)
0ce7267 
### Rationale for this change

Add residual filter support to swiss join.

### What changes are included in this PR?

1. Added class `JoinResidualFilter` as a centralized structure to evaluate residual filter in swiss join. It has various flavors of filtering for various join types. Zero-overhead is guaranteed for trivial filters (literal true and sometimes literal false/null). More detailed explanation in code comments.
2. Tuned the structure of swiss join main body (`JoinProbeProcessor::OnNextBatch`) to better cope with `JoinResidualFilter` calls.

### Are these changes tested?

Legacy UTs (`HashJoin.Random`, `HashJoin.ResidualFilter` and `HashJoin.TrivialResidualFilter`) cover part of this change. New fine-grained residual filter cases added as well.

### Are there any user-facing changes?

No.

* Closes: #20339

Lead-authored-by: zanmato <[email protected]>
Co-authored-by: zanmato1984 <[email protected]>
Co-authored-by: Ruoxi Sun <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: Weston Pace <[email protected]>
@westonpace westonpace added this to the 16.0.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanmato1984 zanmato1984

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-20339: [C++] Add residual filter support to swiss join zanmato1984/arrow
4 participants
@raulcd @zanmato1984 @westonpace @asfimport