-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-36240: [Python] Refactor CumulativeSumOptions to a separate class …
…for independent deprecation (#36977) **Rationale for this change** As #36240 says, we refactor CumulativeSumOptions to a separate class. **What changes are included in this PR?** - independent CumulativeSumOptions - the original simple test before #32190 - fix a typo in CumulativeOptions **Are these changes tested?** No. Actually, the PR can't pass the `test_option_class_equality` in test_compute.py ([Error example](https://github.com/apache/arrow/actions/runs/5728571658/job/15523443371?pr=36977)). Cause CumulativeSumOptions's C++ part is also CumulativeOptions. ![image](https://github.com/apache/arrow/assets/18380073/0a173684-47f8-4eb9-b8f4-ba72aa5aab97) **Are there any user-facing changes?** No. Closes: #36240 * Closes: #36240 Lead-authored-by: Junming Chen <[email protected]> Co-authored-by: Dane Pitkin <[email protected]> Co-authored-by: Alenka Frim <[email protected]> Signed-off-by: AlenkaF <[email protected]>
- Loading branch information
1 parent
369bb31
commit fe750ed
Showing
3 changed files
with
31 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters