Re-add silencing of rosetta detection, move test

apache · Oct 12, 2023 · dfec06a · dfec06a
1 parent 19684dd
commit dfec06a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 23 deletions.
diff --git a/r/R/install-arrow.R b/r/R/install-arrow.R
@@ -270,6 +270,7 @@ wslify_path <- function(path) {
 }
 
 on_rosetta <- function() {
+  # make sure to suppress warnings and ignore the stderr so that this is silent where proc_translated doesn't exist
   identical(tolower(Sys.info()[["sysname"]]), "darwin") &&
-    identical(system("sysctl -n sysctl.proc_translated", intern = TRUE), "1")
-}
+    identical(suppressWarnings(system("sysctl -n sysctl.proc_translated", intern = TRUE, ignore.stderr = TRUE)), "1")
+}
diff --git a/r/tests/testthat/test-arrow-pacakge.R b/r/tests/testthat/test-arrow-pacakge.R
diff --git a/r/tests/testthat/test-install-arrow.R b/r/tests/testthat/test-install-arrow.R
@@ -33,3 +33,8 @@ test_that("arrow_repos", {
     expect_identical(arrow_repos(c(ours, other), nightly = TRUE), c(ours, other))
   })
 })
+
+test_that("on_rosetta() does not warn", {
+  # There is no warning
+  expect_warning(on_rosetta(), NA)
+})