Revert have_default_file_metadata()

We've implemented file metadata for Azure Filesystem.
apache · Mar 28, 2024 · d4dd4f1 · d4dd4f1
1 parent 9e99838
commit d4dd4f1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/cpp/src/arrow/filesystem/azurefs_test.cc b/cpp/src/arrow/filesystem/azurefs_test.cc
@@ -382,8 +382,7 @@ class TestAzureFileSystemGeneric : public ::testing::Test, public GenericFileSys
   bool allow_append_to_file() const override { return true; }
   bool have_directory_mtimes() const override { return false; }
   bool have_flaky_directory_tree_deletion() const override { return false; }
-  bool have_file_metadata() const override { return false; }
-  bool have_default_file_metadata() const override { return true; }
+  bool have_file_metadata() const override { return true; }
 
   std::shared_ptr<AzureFileSystem> azure_fs_;
   std::shared_ptr<FileSystem> fs_;

diff --git a/cpp/src/arrow/filesystem/test_util.cc b/cpp/src/arrow/filesystem/test_util.cc
@@ -926,11 +926,7 @@ void GenericFileSystemTest::TestOpenOutputStream(FileSystem* fs) {
     ASSERT_OK_AND_EQ("x-arrow/filesystem-test", got_metadata->Get("Content-Type"));
   } else {
     if (got_metadata) {
-      if (have_default_file_metadata()) {
-        ASSERT_GT(got_metadata->size(), 0);
-      } else {
-        ASSERT_EQ(got_metadata->size(), 0);
-      }
+      ASSERT_EQ(got_metadata->size(), 0);
     }
   }
 

diff --git a/cpp/src/arrow/filesystem/test_util.h b/cpp/src/arrow/filesystem/test_util.h
@@ -184,8 +184,6 @@ class ARROW_TESTING_EXPORT GenericFileSystemTest {
   virtual bool have_flaky_directory_tree_deletion() const { return false; }
   // - Whether the filesystem stores some metadata alongside files
   virtual bool have_file_metadata() const { return false; }
-  // - Whether the filesystem returns some default metadata alongside files
-  virtual bool have_default_file_metadata() const { return false; }
 
   void TestEmpty(FileSystem* fs);
   void TestNormalizePath(FileSystem* fs);