Skip to content

Commit

Permalink
fix compiler warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
nevi-me committed Nov 19, 2019
1 parent 84e31b7 commit cc38646
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion rust/arrow/src/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ pub unsafe fn memcpy(dst: *mut u8, src: *const u8, len: usize) {
}

extern "C" {
#[inline]
pub fn memcmp(p1: *const u8, p2: *const u8, len: usize) -> i32;
}

Expand Down
2 changes: 0 additions & 2 deletions rust/parquet/src/encodings/decoding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -657,10 +657,8 @@ impl<T: DataType> Decoder<T> for DeltaBitPackDecoder<T> {
/// Helper trait to define specific conversions when decoding values
trait DeltaBitPackDecoderConversion<T: DataType> {
/// Sets decoded value based on type `T`.
#[inline]
fn get_delta(&self, index: usize) -> i64;

#[inline]
fn set_decoded_value(&self, buffer: &mut [T::T], index: usize, value: i64);
}

Expand Down
5 changes: 0 additions & 5 deletions rust/parquet/src/encodings/encoding.rs
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@ impl<T: DataType> Encoder<T> for DictEncoder<T> {
/// Provides encoded size for a data type.
/// This is a workaround to calculate dictionary size in bytes.
trait DictEncodedSize<T: DataType> {
#[inline]
fn get_encoded_size(&self, value: &T::T) -> usize;
}

Expand Down Expand Up @@ -752,16 +751,12 @@ impl<T: DataType> Encoder<T> for DeltaBitPackEncoder<T> {
/// Helper trait to define specific conversions and subtractions when computing deltas
trait DeltaBitPackEncoderConversion<T: DataType> {
// Method should panic if type is not supported, otherwise no-op
#[inline]
fn assert_supported_type();

#[inline]
fn as_i64(&self, values: &[T::T], index: usize) -> i64;

#[inline]
fn subtract(&self, left: i64, right: i64) -> i64;

#[inline]
fn subtract_u64(&self, left: i64, right: i64) -> u64;
}

Expand Down

0 comments on commit cc38646

Please sign in to comment.