Skip to content

Commit

Permalink
MINOR: [CI] Update allowed_roles for crossbow submission (#39610)
Browse files Browse the repository at this point in the history
### Rationale for this change

Improved security, this aligns the permissions with the current default repo setting of required approval for all contributors.

### What changes are included in this PR?

Only committers (members,owner and collaborator of ASF org) can submit a crossbow job.

### Are these changes tested?
Not possible.

Authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
assignUser authored Jan 16, 2024
1 parent 809244e commit b59082a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev/archery/archery/bot.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def handle_issue_comment(self, command, payload):
# https://developer.github.com/v4/enum/commentauthorassociation/
# Checking privileges here enables the bot to respond
# without relying on the handler.
allowed_roles = {'OWNER', 'MEMBER', 'CONTRIBUTOR', 'COLLABORATOR'}
allowed_roles = {'OWNER', 'MEMBER', 'COLLABORATOR'}
if payload['comment']['author_association'] not in allowed_roles:
raise EventError(
"Only contributors can submit requests to this bot. "
Expand Down

0 comments on commit b59082a

Please sign in to comment.