Fix remaining unit tests

apache · Jul 29, 2022 · b0d5cdc · b0d5cdc
1 parent c6d8411
commit b0d5cdc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/cpp/src/arrow/compute/kernel_test.cc b/cpp/src/arrow/compute/kernel_test.cc
@@ -145,9 +145,11 @@ TEST(InputType, Equals) {
   ASSERT_NE(InputType(int8()), InputType(Type::INT32));
 
   // Check that field metadata excluded from equality checks
-  InputType t9 = list(
+  auto ty9 = list(
       field("item", utf8(), /*nullable=*/true, key_value_metadata({"foo"}, {"bar"})));
-  InputType t10 = list(field("item", utf8()));
+  auto ty10 = list(field("item", utf8()));
+  InputType t9 = ty9.get();
+  InputType t10 = ty10.get();
   ASSERT_TRUE(t9.Equals(t10));
 }
 

diff --git a/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h b/cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
@@ -229,7 +229,9 @@ struct SumLikeInit {
   }
 
   Status Visit(const BooleanType&) {
-    state.reset(new KernelClass<BooleanType>(boolean().get(), options));
+    const DataType* ty =
+        TypeTraits<typename KernelClass<BooleanType>::SumType>::type_singleton().get();
+    state.reset(new KernelClass<BooleanType>(ty, options));
     return Status::OK();
   }
 

diff --git a/cpp/src/arrow/compute/kernels/hash_aggregate.cc b/cpp/src/arrow/compute/kernels/hash_aggregate.cc
@@ -2802,7 +2802,7 @@ void PopulateNumericHashKernels(Result<HashAggregateKernel> make_kernel(const Da
         AddHashAggKernels({null().get(), boolean().get()}, make_kernel, func.get()));
   }
   // Type parameters are ignored
-  DCHECK_OK(AddHashAggKernels(decimal_types, GroupedTDigestFactory::Make, func.get()));
+  DCHECK_OK(AddHashAggKernels(decimal_types, make_kernel, func.get()));
   DCHECK_OK(registry->AddFunction(std::move(func)));
 }