Skip to content

Commit

Permalink
GH-39119: [C++] Refactor the Azure FS tests and filesystem class inst…
Browse files Browse the repository at this point in the history
…antiation (#39207)

### Rationale for this change

This PR contains some unrelated improvements (like better docs) and some nitpicky fixes. The test refactoring makes it easier to see on which environments tests run and make them able to be instantiated with different options in the future once we extend the `AzureOptions`.

### What changes are included in this PR?

 - Random cleanups
 - Short namespace aliases
 - Refactoring of the tests (multiple environments, TYPED_TEST_SUITE, explicit preexisting data setup)
 - Cleanup of the `AzureOptions` class

### Are these changes tested?

Yes. I created Azure Storage accounts to test with and without Hierarchical Namespace support. I also ran the tests in a shell without my environment variables to ensure the test-skipping behavior is correct.

### Are there any user-facing changes?

Changes to `AzureOptions`, but since `AzureFileSystem` is not really used yet, these breaking changes won't be a problem.
* Closes: #39119

Authored-by: Felipe Oliveira Carvalho <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
  • Loading branch information
felipecrv authored Dec 14, 2023
1 parent a4fae02 commit 4e58f7c
Show file tree
Hide file tree
Showing 5 changed files with 1,094 additions and 893 deletions.
Loading

0 comments on commit 4e58f7c

Please sign in to comment.